Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add slither #70

Closed
varunsrin opened this issue Aug 27, 2022 · 3 comments
Closed

ci: add slither #70

varunsrin opened this issue Aug 27, 2022 · 3 comments
Labels
help wanted Extra attention is needed test Problems with the test suite

Comments

@varunsrin
Copy link
Member

adding slither to our ci would be useful for catching issues as they come up, as long as it can be executed in a reasonable amount of time and does not have too many false positives

@varunsrin varunsrin added help wanted Extra attention is needed test Problems with the test suite labels Sep 24, 2022
@varunsrin
Copy link
Member Author

a template for this is now available here: https://github.com/ScopeLift/foundry-template

@GarrettJMU
Copy link

Missed this already had a PR - happy to close mine but this should work.

https://github.com/farcasterxyz/contracts/pull/192/files

@GarrettJMU GarrettJMU mentioned this issue Mar 3, 2023
4 tasks
@varunsrin
Copy link
Member Author

Don't seem to be able to get this below 11 minutes, which may not make sense for a CI process that runs on every small change. It may be faster to just have a manual process of running slither and fixing issues before release, since its such a manual process anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed test Problems with the test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants