-
-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add field-level db comments when a field description exists #1293
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the contribution!
There are some linting errors and test failures - could you look into those? It will facilitate the review process if the CI is green. I'll go ahead and put this PR in draft in the meantime 🙏
9f6e01c
to
3db51e0
Compare
ae4efaf
to
67bea0f
Compare
@svlandeg awesome, will work on CI and we can go from there! Is there anything else that I should work on in order to get this merged? |
A test case is always useful, as it helps the reviewer as well to quickly run a small example. And it'll likely be necessary anyway to get the test coverage back to 100% (ensuring that all code in the code base gets tested). |
Awesome, I should have some time to help there. I have a bunch of other SQLModel improvements I'd love to pull over from activemodel, so understanding the best contribution flow would be really helpful |
Sure thing, let me know if you have specific questions/doubts about contributing to |
This PR fixes #492 (comment) by adding column-level db comments
when a field description exists.
I can add some tests if this is the sort of PR that would be accepted.
I've implemented this in my SQLModel extension here: https://github.com/iloveitaly/activemodel/blob/master/activemodel/get_column_from_field_patch.py
Details: