Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key highlighting fails to render when using --load-config #377

Closed
cloudymax opened this issue Jan 1, 2023 · 3 comments
Closed

Key highlighting fails to render when using --load-config #377

cloudymax opened this issue Jan 1, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@cloudymax
Copy link

cloudymax commented Jan 1, 2023

Hoi all 👋, thanks for making this awesome project!

I noticed an inconsistency between --locad-config and --iterm with regards to key highlighting.

General description of bug:

When calling fastfetch from the commandline using the --iterm flag, key-highlighting renders as expected

Screenshot 2023-01-01 at 15 39 54

When creating a config file using the same values and the calling fastfetch using the --load-config <myConfig> method, key-highlighting does not render.

Screenshot 2023-01-01 at 15 40 24

the config:

# Logo option:
# Sets the logo to use.
# List available logos with "fastfetch --list-logos".
# Print available logos with "fastfetch --print-logos".
# Must be the name of an available logo or a path to a text file containing a custom logo.
# Default is the current distribution.
--logo /Users/max/Desktop/Pictures/gifs/skull_spookyhacker.gif

# Logo type option:
# Sets the logo type to use.
# Must be auto, builtin, file, file-raw, data, data-raw, sixel, kitty or chafa.
# Default is auto.
--logo-type iterm

# Logo width option:
# Sets the width of the logo (in characters) if the logo is an image.
# Must be a positive integer.
# Default is 65.
--logo-width 25

# Logo height option:
# Sets the height of the logo (in characters) if the logo is an image.
# Must be a positive integer.
# Default is 0 (keeps aspect ration).
--logo-height 12

Often helpful questions:

  • Does the issue occur across multiple terminal emulators? Only tested using iTerm

  • Does the issue occur across multiple shells? only tested using bash

Output of fastfetch --version:

fastfetch 1.8.2-5

Output of fastfetch --load-config devinfo:

Screenshot 2023-01-01 at 15 56 47

Output of fastfetch --load-config devinfo-verbose:

    [email protected]
       ---------------
       OS: System: Darwin; Name: macOS; Pretty name: macOS; ID: macos; ID like: ; Variant: ; Variant ID: ; Version: 13.0.1; Version ID: 13.0.1; Version codename: Ventura; Build ID: 22A400; Architecture: arm64
       Host: Family: MacBookPro17,1; Name: MacBook Pro (13-inch, M1, 2020); Version:
       Bios: iBoot-8419.41.10
       Board: Not supported on this platform
       Chassis: Not supported on this platform
       Kernel: Sysname: Darwin; Release: 22.1.0; Version: Darwin Kernel Version 22.1.0: Sun Oct  9 20:14:30 PDT 2022; root:xnu-8792.41.9~2/RELEASE_ARM64_T8103
       Uptime: Days: 12; Hours: 18; Minutes: 34; Seconds: 5
       Processes: Count: 344
                                Packages: All: 283; pacman: 0; pacman branch: ; dpkg: 0; rpm: 0; xbps: 0; flatpak: 0; snap: 0
                                Shell: Process name: bash; Process path: /opt/homebrew/Cellar/bash/5.2.15/bin/bash; Process exe: bash; Process version: 5.2.15; User path: /opt/homebrew/bin/bash; User exe: bash; User version: 5.2.15
                                Resolution: Width: 1680; Height: 1050; Refresh rate: 60
                                DE: Session desktop: aqua; Process name: Aqua; Pretty name: ; Version: {}
                                WM: Session desktop: quartz; Process name: Quartz Compositor; Pretty name: ; Protocol: {}
                                WM Theme: Name: Multicolor (Dark)
                                Theme: Theme detection is not supported
                                Icons: Icons detection is not supported
                                Font: Plasma raw: .AppleSystemUIFont; Plasma name: Helvetica; Plasma size: .AppleSystemUIFontMonospaced; Plasma styles: Menlo; Plasma pretty: {}; GTK2 raw: {}; GTK2 name: {}; GTK2 size: {}; GTK2 styles: {}; GTK2 pretty: {}; GTK3 raw: {}; GTK3 name: {}; GTK3 size: {}; GTK3 styles: {}; GTK3 pretty: {}; GTK4 raw: {}; GTK4 name: {}; GTK4 size: {}; GTK4 styles: {}; GTK4 pretty: {}; GTK: {}
                                Cursor: Not supported on this platform
                                Terminal: Process: iTerm.app; Path: iTerm.app; Exe:
                                Terminal Font: Raw: CozetteVector-Regular (18pt); Name: CozetteVector-Regular; Size: 18; Styles: ; Pretty: {}
                                CPU: Name: Apple M1; Pretty: ; Vendor: 8; Logical online: 8; Logical configured: 8; Physical: 0; Cores: 0; bios: nan; scaling max: {}; scaling min: {}; info max: {}; info min: {}; cpuinfo: {}; frequency: {}
                                CPU Usage: 58.18%
                                GPU: Vendor: ; Vendor pretty: Apple M1; Name: com.apple.AGXG13G; Name pretty: nan
                                Memory: Used: 2.77 GiB; Total: 8.00 GiB; Percentage: 34
                                Swap: 1.60 GiB / 2.00 GiB (79%)
                                Disk (/): Used: 125 GiB; Total: 228 GiB; Files: 54; Percentage: 348618
                                Battery: Manufactor: Apple Inc.; Model: Builtin; Technology: Lithium; Capacaty: 27; Status:
                                Power Adapter: not connected
                                Media Player: MRMediaRemoteGetNowPlayingInfo() failed
                                Media: MRMediaRemoteGetNowPlayingInfo() failed
                                Date & Time: 2023-01-1 15:54:19
                                Locale: C
                                Vulkan: dlopen libvulkan.dylib failed
                                OpenGL: 4.1 Metal - 83
                                OpenCL: 1.2
                                Users: max
                                Weather: +12°C - Sunny (Vlaardingen, Netherlands)

Output of fastfetch --list-features:

vulkan
imagemagick7
chafa
zlib
@cloudymax cloudymax added the bug Something isn't working label Jan 1, 2023
@cloudymax cloudymax changed the title Key high-lighting fails to render when using --load-config instead of --iterm logo type Key highlighting fails to render when using --load-config instead of --iterm logo type Jan 1, 2023
@cloudymax cloudymax changed the title Key highlighting fails to render when using --load-config instead of --iterm logo type Key highlighting fails to render when using --load-config instead of --iterm logo type Jan 1, 2023
@jessebot
Copy link
Contributor

jessebot commented Jan 2, 2023

Looks like I'm also getting this with --logo-type sixel as well for both the keys and the title (happens on both macOS Ventura and Ubuntu 22.04):

Screenshot 2023-01-02 at 10 17 33

But it only occurs when using --load-config. If I move the same preset config to $XDG_CONFIG_HOME/fastfetch/config.conf the highlighting works again:

Screenshot 2023-01-02 at 10 28 00

@cloudymax cloudymax changed the title Key highlighting fails to render when using --load-config instead of --iterm logo type Key highlighting fails to render when using --load-config Jan 8, 2023
@CarterLi
Copy link
Member

CarterLi commented Aug 7, 2023

I can't reproduce this issue. If this issue still occurs for you in the latest dev build, feel free to reopen it

@CarterLi CarterLi closed this as completed Aug 7, 2023
@jessebot
Copy link
Contributor

jessebot commented Aug 7, 2023

Thanks! I'll try to check again and let you know if that's the case :) Hope you and the other maintainers are doing well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants