Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Shell & Terminal detection broken with /bin/sh as login shell #798

Closed
JamiKettunen opened this issue Apr 17, 2024 · 2 comments
Closed

[BUG] Shell & Terminal detection broken with /bin/sh as login shell #798

JamiKettunen opened this issue Apr 17, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@JamiKettunen
Copy link
Contributor

https://github.com/fastfetch-cli/fastfetch/blob/2.9.2/src/detection/terminalshell/terminalshell_linux.c#L222 is a problem on Chimera Linux for example where /bin/sh is the default shell unless you install and start using something else.

Since fastfetch is packaged in the contrib repo one could simply run this post-install and see broken Shell: kgx & Terminal: dinit

doas apk add chimera-repo-contrib
doas apk add fastfetch
fastfetch

Regarding the comment shouldn't pipes/redirects be detected with something similar to test -t 1 in shellscript or are there other cases this also happens to catch? Maybe some smarter heuristic could be done anyway :)
@JamiKettunen JamiKettunen added the bug Something isn't working label Apr 17, 2024
@CarterLi
Copy link
Member

Please check the latest dev build works for you

@JamiKettunen
Copy link
Contributor Author

Thanks for the quick fix, seems to work ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CarterLi @JamiKettunen