Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a typescript generic type error #280

Closed
2 tasks done
XHFkindergarten opened this issue Dec 19, 2023 · 0 comments · Fixed by #282
Closed
2 tasks done

fix a typescript generic type error #280

XHFkindergarten opened this issue Dec 19, 2023 · 0 comments · Fixed by #282

Comments

@XHFkindergarten
Copy link
Contributor

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the bug has not already been reported

Fastify version

x

Plugin version

x

Node.js version

x

Operating system

Linux

Operating system version (i.e. 20.04, 11.3, 10)

x

Description

I'm trying to practice a tutorial of Platformatic,and in this template, compilerOptions.skipLibCheck is not on. so it exposed a problem of @fastify/websocket。
image
and typescript should output:
Generic type 'RouteShorthandMethod<RawServer, RawRequest, RawReply, TypeProvider>' requires between 0 and 4 type arguments.

i think the Logger generic parameter is useless and should be removed.

Steps to Reproduce

https://docs.platformatic.dev/docs/getting-started/movie-quotes-app-tutorial

Expected Behavior

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant