Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP client never closes response body #362

Closed
makhov opened this issue Sep 7, 2022 · 1 comment · Fixed by #363
Closed

HTTP client never closes response body #362

makhov opened this issue Sep 7, 2022 · 1 comment · Fixed by #363

Comments

@makhov
Copy link

makhov commented Sep 7, 2022

This leads to too many open files error.

According to the net/http package docs, the client must close the response body when finished with it.
@Integralist
Copy link
Collaborator

Thanks for raising this issue @makhov

I'll take a look into this and raise a PR to correct.

@makhov makhov changed the title HTTP client never closes request body HTTP client never closes response body Sep 7, 2022
@Integralist Integralist mentioned this issue Sep 7, 2022
Merged
@Integralist Integralist mentioned this issue Sep 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure http.Response.Body is closed fastly/go-fastly
2 participants
@Integralist @makhov