s3logging: default S3 domain to s3.amazonaws.com to match api default #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set default value for the
domain
attribute in thes3logging
block. Right now if it's not in us-east-1, you need to specify a value, but it seems now that the API will provide a default ofs3.amazonaws.com
so we need to match it.Users specifying any valid value are unaffected, and users without a value are seeing a perpetual diff, so this should be fine in terms of backwards compatibility regarding the struct hash.
All our existing tests supplied a value here, so I add a new test with that uses the default.
Should fix #10 /cc @DanielRussell