Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condition types are now uppercase #148

Closed
alanfriedman opened this issue May 3, 2019 · 1 comment · Fixed by #149
Closed

Condition types are now uppercase #148

alanfriedman opened this issue May 3, 2019 · 1 comment · Fixed by #149

Comments

@alanfriedman
Copy link

alanfriedman commented May 3, 2019

Terraform Version

0.11.7 Linux AMD 64

Affected Resource(s)

  • condition

Fastly provider version 0.6.0
AWS provider version 2.8.0

Actual Behavior

condition blocks used to accept a lowercase type (request, response, etc). Now it appears they require uppercase types (REQUEST, RESPONSE).

The lowercase types stopped working sometime after April 15th. We never bumped the major version of Terraform or the Fastly provider so did not expect a breaking change.

Expected Behavior

I would expect the lowercase types to continue working when using the same Terraform and provider versions.

@philippschulte
Copy link
Member

👋 I can't confirm the described behavior. You can still use lowercase values for the type attribute. However, by doing so the plan command will always detect a difference. For example request is not equal to REQUEST because the Go programming language is case sensitive and the Fastly API will always respond with an uppercase value even if the condition was created with a lowercase type value.

Also, both the Fastly API and the Fastly Terraform docs require uppercase values for the condition type attribute. This hasn't changed since conditions are supported. Please have a look here in case you want to prove it yourself. The only issue I see is that the provider should throw an error if the value for the type attribute is not uppercase and not one of the required types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants