Support hash Snippet Types #211
Conversation
The type `"hash"` appears to be missing from the list of valid Snippet Types. Fastly's documentation for allowable types https://docs.fastly.com/api/config#api-section-snippet
ghost
added
the
|
It looks like the Travis build passed but is still showing Pending in GitHub: https://travis-ci.org/terraform-providers/terraform-provider-fastly/builds/654597126?utm_medium=notification&utm_source=github_status |
|
Is there a process for getting this looked at? |
There was a problem hiding this comment.
@soldiermoth thanks for your contribution and sorry for the delay in getting back to you! Every validator is covered by unit tests. Therefore, please add the new type to TestValidateSnippetType located at fastly/validators_test.go. Thank you
|
@philippschulte No worries, thanks for getting back to me. Happy to add it to those tests, should be good to go now. |
There was a problem hiding this comment.
@soldiermoth thanks for updating the test. I also wanted to confirm @phamann is happy with this before merging.
There was a problem hiding this comment.
Apologies for the delayed response, yes I'm happy 👍
Thank you for your contribution @soldiermoth
The type
"hash"appears to be missing from the list of valid Snippet Types.Fastly's documentation for allowable types https://docs.fastly.com/api/config#api-section-snippet