Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a mention to the hardcoded relatives crate path #1

Closed
amtoine opened this issue Feb 22, 2023 · 3 comments
Closed

add a mention to the hardcoded relatives crate path #1

amtoine opened this issue Feb 22, 2023 · 3 comments

Comments

@amtoine
Copy link

amtoine commented Feb 22, 2023

hello there πŸ‘‹ πŸ˜‹

this plugin is very cool πŸ‘Œ πŸ’ͺ

❗ however, i have an error when trying to compile the source code as-is πŸ€”

> cargo build --release
error: failed to get `nu-json` as a dependency of package `nu_plugin_json_path v0.0.3 (/home/amtoine/.local/share/git/store/github.com/fdncred/nu_plugin_json_path)`

Caused by:
  failed to load source for dependency `nu-json`

Caused by:
  Unable to update /home/amtoine/.local/share/git/store/github.com/fdncred/nushell/crates/nu-json

Caused by:
  failed to read `/home/amtoine/.local/share/git/store/github.com/fdncred/nushell/crates/nu-json/Cargo.toml`

Caused by:
  No such file or directory (os error 2)

πŸ”§ to fix it
as my repos are located in $env.GIT_REPOS_HOME/<host>/<owner>/<repo>, i had to run the following

>_ [nu-json nu-plugin nu-protocol]
))) | each {|crate|
)))     let local = ($env.GIT_REPOS_HOME | path join "github.com" "nushell" "nushell" "crates" $crate)
)))     cargo add $crate --path $local
))) }
      Adding nu-json (local) to dependencies.
             Features:
             + linked-hash-map
             + preserve_order
      Adding nu-plugin (local) to dependencies.
      Adding nu-protocol (local) to dependencies.
             Features:
             - plugin
             - serde_json

in the end, nothing bad at all, when the error is known it's straightforward to fix πŸ˜‰

that's just a proposition with the newcomers in mind 😌

@fdncred
Copy link
Owner

fdncred commented Feb 22, 2023

Thanks. I added your comments to the readme. I also removed nu-json because it isn't needed.

@fdncred fdncred closed this as completed Feb 22, 2023
@amtoine
Copy link
Author

amtoine commented Feb 22, 2023

amazing, that's perfect πŸ‘Œ

@maxim-uvarov
Copy link

Absolutely cool plugin! I was able to install with no customization on the latest Macos.
Just fyi. πŸ™πŸ™πŸ™

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants