From 6be62fb1e96eaf6470c16eb5ccddb788494ec4d1 Mon Sep 17 00:00:00 2001
From: Daniel Kim <danielk@twitter.com>
Date: Thu, 23 Jun 2022 11:50:05 -0700
Subject: [PATCH] Rename instances of metadata to data

Signed-off-by: Daniel Kim <danielk@twitter.com>
---
 .../DataQuery.tsx}                            |  8 +++---
 .../MetadataTab.tsx => data-tab/DataTab.tsx}  | 28 +++++++++----------
 ui/src/index.tsx                              |  8 +++---
 .../useLoadFeatureViewSummaryStatistics.ts    |  2 +-
 4 files changed, 23 insertions(+), 23 deletions(-)
 rename ui/src/custom-tabs/{metadata-tab/MetadataQuery.tsx => data-tab/DataQuery.tsx} (69%)
 rename ui/src/custom-tabs/{metadata-tab/MetadataTab.tsx => data-tab/DataTab.tsx} (73%)

diff --git a/ui/src/custom-tabs/metadata-tab/MetadataQuery.tsx b/ui/src/custom-tabs/data-tab/DataQuery.tsx
similarity index 69%
rename from ui/src/custom-tabs/metadata-tab/MetadataQuery.tsx
rename to ui/src/custom-tabs/data-tab/DataQuery.tsx
index 2fc3d41450..f101c122e4 100644
--- a/ui/src/custom-tabs/metadata-tab/MetadataQuery.tsx
+++ b/ui/src/custom-tabs/data-tab/DataQuery.tsx
@@ -1,11 +1,11 @@
 import { useQuery } from "react-query";
 
-interface MetadataQueryInterface {
+interface DataQueryInterface {
   featureView: string | undefined;
 }
 
-const MetadataQuery = (featureView: string) => {
-  const queryKey = `metadata-tab-namespace:${featureView}`;
+const DataQuery = (featureView: string) => {
+  const queryKey = `data-tab-namespace:${featureView}`;
 
   return useQuery<any>(
     queryKey,
@@ -22,4 +22,4 @@ const MetadataQuery = (featureView: string) => {
   );
 };
 
-export default MetadataQuery;
+export default DataQuery;
diff --git a/ui/src/custom-tabs/metadata-tab/MetadataTab.tsx b/ui/src/custom-tabs/data-tab/DataTab.tsx
similarity index 73%
rename from ui/src/custom-tabs/metadata-tab/MetadataTab.tsx
rename to ui/src/custom-tabs/data-tab/DataTab.tsx
index 50d033febe..144083420a 100644
--- a/ui/src/custom-tabs/metadata-tab/MetadataTab.tsx
+++ b/ui/src/custom-tabs/data-tab/DataTab.tsx
@@ -15,20 +15,20 @@ import {
   EuiTableRowCell,
 } from "@elastic/eui";
 import useLoadRegularFeatureView from "../../pages/feature-views/useLoadFeatureView";
-import MetadataQuery from "./MetadataQuery";
+import DataQuery from "./DataQuery";
 
-const FeatureViewMetadataRow = z.object({
+const FeatureViewDataRow = z.object({
   name: z.string(),
   value: z.string(),
 });
 
-type FeatureViewMetadataRowType = z.infer<typeof FeatureViewMetadataRow>;
+type FeatureViewDataRowType = z.infer<typeof FeatureViewDataRow>;
 
 const LineHeightProp: React.CSSProperties = {
   lineHeight: 1,
 }
 
-const EuiFeatureViewMetadataRow = ({name, value}: FeatureViewMetadataRowType) => {
+const EuiFeatureViewDataRow = ({name, value}: FeatureViewDataRowType) => {
   return (
     <EuiTableRow>
       <EuiTableRowCell>
@@ -45,11 +45,11 @@ const EuiFeatureViewMetadataRow = ({name, value}: FeatureViewMetadataRowType) =>
   );
 }
 
-const FeatureViewMetadataTable = (data: any) => {
-  var items: FeatureViewMetadataRowType[] = [];
+const FeatureViewDataTable = (data: any) => {
+  var items: FeatureViewDataRowType[] = [];
 
   for (let element in data.data){
-    const row: FeatureViewMetadataRowType = {
+    const row: FeatureViewDataRowType = {
       name: element,
       value: JSON.stringify(data.data[element], null, 2),
     };
@@ -61,22 +61,22 @@ const FeatureViewMetadataTable = (data: any) => {
     <EuiTable>
       <EuiTableHeader>
         <EuiTableHeaderCell>
-          Metadata Item Name
+          Data Item Name
         </EuiTableHeaderCell>
         <EuiTableHeaderCell>
-          Metadata Item Value
+          Data Item Value
         </EuiTableHeaderCell>
       </EuiTableHeader>
       {items.map((item) => {
-        return <EuiFeatureViewMetadataRow name={item.name} value={item.value} />
+        return <EuiFeatureViewDataRow name={item.name} value={item.value} />
       })}
     </EuiTable>
   )
 }
 
-const MetadataTab = () => {
+const DataTab = () => {
   const fName = "credit_history"
-  const { isLoading, isError, isSuccess, data } = MetadataQuery(fName);
+  const { isLoading, isError, isSuccess, data } = DataQuery(fName);
   const isEmpty = data === undefined;
 
   return (
@@ -97,7 +97,7 @@ const MetadataTab = () => {
               <h3>Properties</h3>
             </EuiTitle>
             <EuiHorizontalRule margin="xs" />
-            <FeatureViewMetadataTable data={data} />
+            <FeatureViewDataTable data={data} />
           </EuiPanel>
           </EuiFlexItem>
         </EuiFlexGroup>
@@ -107,4 +107,4 @@ const MetadataTab = () => {
   );
 };
 
-export default MetadataTab;
+export default DataTab;
diff --git a/ui/src/index.tsx b/ui/src/index.tsx
index b90ea9ea6d..937a91e9fa 100644
--- a/ui/src/index.tsx
+++ b/ui/src/index.tsx
@@ -15,7 +15,7 @@ import FeastUI from "./FeastUI";
 // 3. Register the tab in the appropriate array below. Each entry
 //    is a record with three keys: label, path, and Component.
 //    Import your component and pass it as Component
-import MetadataTab from "./custom-tabs/metadata-tab/MetadataTab";
+import DataTab from "./custom-tabs/data-tab/DataTab";
 import RFVDemoCustomTab from "./custom-tabs/reguar-fv-demo-tab/DemoCustomTab";
 import ODFVDemoCustomTab from "./custom-tabs/ondemand-fv-demo-tab/DemoCustomTab";
 import FSDemoCustomTab from "./custom-tabs/feature-service-demo-tab/DemoCustomTab";
@@ -33,9 +33,9 @@ const tabsRegistry = {
       Component: RFVDemoCustomTab,
     },
     {
-      label: "Metadata Tab Demo", // Navigation Label for the tab
-      path: "metadata-tab", // Subpath for the tab
-      Component: MetadataTab,
+      label: "Data Tab Demo", // Navigation Label for the tab
+      path: "data-tab", // Subpath for the tab
+      Component: DataTab,
     },
   ],
   OnDemandFeatureViewCustomTabs: [
diff --git a/ui/src/queries/useLoadFeatureViewSummaryStatistics.ts b/ui/src/queries/useLoadFeatureViewSummaryStatistics.ts
index 0604029866..fea0bd9d81 100644
--- a/ui/src/queries/useLoadFeatureViewSummaryStatistics.ts
+++ b/ui/src/queries/useLoadFeatureViewSummaryStatistics.ts
@@ -9,7 +9,7 @@ const useLoadFeatureViewSummaryStatistics = (featureViewName: string) => {
   const { projectName } = useParams();
 
   const queryKey = `featureViewSummaryStatistics:${featureViewName}`;
-  const url = `/metadata/${projectName}/featureView/${featureViewName}.json`;
+  const url = `/data/${projectName}/featureView/${featureViewName}.json`;
 
   return useQuery(
     queryKey,