From a321d54a101b09d533af2d1c34cbadc41e3ba562 Mon Sep 17 00:00:00 2001 From: Kevin Zhang Date: Tue, 1 Mar 2022 18:03:58 -0800 Subject: [PATCH] Clean up code Signed-off-by: Kevin Zhang --- .github/workflows/pr_integration_tests.yml | 11 +---------- .../integration/feature_repos/repo_configuration.py | 2 +- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/.github/workflows/pr_integration_tests.yml b/.github/workflows/pr_integration_tests.yml index 38df0b2d4f..e04b78ec32 100644 --- a/.github/workflows/pr_integration_tests.yml +++ b/.github/workflows/pr_integration_tests.yml @@ -102,11 +102,6 @@ jobs: # code from the PR. ref: refs/pull/${{ github.event.pull_request.number }}/merge submodules: recursive - - name: Start Redis - uses: supercharge/redis-github-action@1.4.0 - with: - redis-version: ${{ matrix.redis-version }} - redis-port: 12345 - name: Setup Python uses: actions/setup-python@v2 id: setup-python @@ -150,10 +145,6 @@ jobs: run: pip install pip-tools - name: Install dependencies run: make install-python-ci-dependencies - - name: Setup Redis Cluster - run: | - docker pull vishnunair/docker-redis-cluster:latest - docker run -d -p 6001:6379 -p 6002:6380 -p 6003:6381 -p 6004:6382 -p 6005:6383 -p 6006:6384 --name redis-cluster vishnunair/docker-redis-cluster - name: Test python if: ${{ always() }} # this will guarantee that step won't be canceled and resources won't leak env: @@ -174,4 +165,4 @@ jobs: flags: integrationtests env_vars: OS,PYTHON fail_ci_if_error: true - verbose: true \ No newline at end of file + verbose: true diff --git a/sdk/python/tests/integration/feature_repos/repo_configuration.py b/sdk/python/tests/integration/feature_repos/repo_configuration.py index d7e4231d7f..89aea727a6 100644 --- a/sdk/python/tests/integration/feature_repos/repo_configuration.py +++ b/sdk/python/tests/integration/feature_repos/repo_configuration.py @@ -52,7 +52,7 @@ "type": "redis", "redis_type": "redis_cluster", # Redis Cluster Port Forwarding is setup in "pr_integration_tests.yaml" under "Setup Redis Cluster". - "connection_string": "127.0.0.1:7001,127.0.0.1:7002,127.0.0.1:7003", + "connection_string": "127.0.0.1:6001,127.0.0.1:6002,127.0.0.1:6003", } # FULL_REPO_CONFIGS contains the repo configurations (e.g. provider, offline store,