Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring boot CLI logs show up as JSON #104

Closed
syvlabs opened this issue Jan 25, 2019 · 3 comments
Closed

Spring boot CLI logs show up as JSON #104

syvlabs opened this issue Jan 25, 2019 · 3 comments
Labels
good first issue Good for newcomers kind/feature New feature or request

Comments

@syvlabs
Copy link

syvlabs commented Jan 25, 2019

Expected Behavior

CLI logs show up in a human-readable format

Current Behavior

CLI logs show up as JSON:
screen shot 2019-01-25 at 5 01 58 pm

Steps to reproduce

  1. mvn clean compile
  2. java -jar ./core/target/feast-core-0.1.0.jar

Specifications

  • Version: 0.1.0
  • Platform: Linux
  • Subsystem: Debian

Thanks!

@zhilingc
Copy link
Collaborator

We have it in json format so that we can process the logs more easily in stackdriver, but fair point, it makes debugging offline pretty hard. Would it be preferable for the user to be able to choose the type of logs they want to see?

@syvlabs
Copy link
Author

syvlabs commented Jan 25, 2019

@zhilingc I would prefer to have it human-readable by default so that devs just starting out with it could debug easily -- would lower the barrier of entry. Then maybe we can set a flag in deployment to have the logs printed as JSON 😄

@zhilingc zhilingc added kind/feature New feature or request good first issue Good for newcomers labels Jan 30, 2019
@woop
Copy link
Member

woop commented Feb 6, 2019

Should log as human readable text by default after #120 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants