Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zeroed entity value causes materialization to fail #1574

Closed
woop opened this issue May 22, 2021 · 0 comments · Fixed by #1580
Closed

Zeroed entity value causes materialization to fail #1574

woop opened this issue May 22, 2021 · 0 comments · Fixed by #1580
Labels
kind/bug priority/p1

Comments

@woop
Copy link
Member

woop commented May 22, 2021

If the user uses an INT32 entity type, and sets their entity to 0, then type_map.py will throw an exception here https://github.com/feast-dev/feast/blob/master/sdk/python/feast/type_map.py#L207 that says feast_value_type is of type None and does not contain a name field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug priority/p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure that only None types fail predicate woop/feast
1 participant
@woop