Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ".with_name" method to FeatureView (Part of shadow entities mapping changes) #1867

Closed
mavysavydav opened this issue Sep 15, 2021 · 0 comments · Fixed by #1872
Closed
Assignees

Comments

@mavysavydav
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
As part of the shadow entities mapping agreed design, we'll need this method. This method will prevent name collisions when the same FeatureView is joined more than once onto to the entity data. Here's the RFC - https://docs.google.com/document/d/1TsCwKf3nVXTAfL0f8i26jnCgHA3bRd4dKQ8QdM87vIA/edit#

Describe the solution you'd like
A clear and concise description of what you want to happen.
Add a ".with_name" method to FeatureView class that'll return a copy of the FeatureView with the passed name instead.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

We considered having a name be automatically produced in the shadow entities that has the shadow entity join_keys included in the name. The issue with this is that the name may become too long in the case of composite entities. We also considered just having a numerical counter in the name like fv_name_0_feature_name, fv_name_1_feature_name.

Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant