Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward-port Cassandra storage support for v0.4+ #335

Closed
ches opened this issue Nov 27, 2019 · 5 comments
Closed

Forward-port Cassandra storage support for v0.4+ #335

ches opened this issue Nov 27, 2019 · 5 comments

Comments

@ches
Copy link
Member

ches commented Nov 27, 2019

#360 implemented ingestion and serving support for Cassandra, for the v0.3 series of Feast. It is considered experimental: we the implementers have not run it in production and are in the process of stress testing.

Project Namespacing (#359 and others) and async job management (#361), coming along near the same time, brought significant changes to Feast internals for v0.4. Consequently, forward-porting the Cassandra support is not trivial.

As contributors of the functionality, we are evaluating our timeline for whether we can change course for Feast v0.4+, or will need to go to production on v0.3 and update on a later schedule. In the former case, we will take on this porting task in the next 1-2 months (Jan-Feb), but in the latter case, we would welcome anyone else interested in Cassandra for v0.4+ to run with implementing it—tag @smadarasmi and @ches and we'll be happy to review, or answer questions about the existing implementation; I'm also in the public Feast Slack channel.

We will also most likely wait for dust to settle on decisions like Feature Set Versioning (#386) before we revisit the implementation.

I will update this issue accordingly when our timeline is clear.

@woop
Copy link
Member

woop commented Nov 28, 2019

@ches Super excited about this!

I think you are right. We can merge this in and simply mark this as experimental at the start.

I would love to be able to review this as well. Specifically want to see which changes you have made to interfaces for writing/reading, if any.

@ches
Copy link
Member Author

ches commented Nov 28, 2019

Specifically want to see which changes you have made to interfaces for writing/reading, if any.

We've mostly tried to avoid it so as not to stretch the scope of review with extra refactoring, but it is something I'm playing with as a separate follow-up.

I have the other matters discussed in chat still in my hopper to file as issues, I'll include that as well.

@ches ches changed the title Add storage support for Cassandra Storage support for Cassandra Dec 11, 2019
@ches
Copy link
Member Author

ches commented Jan 9, 2020

Support was merged for the v0.3 series in #360. The work was done before major changes for Project Namespacing (#359 and others that followed) landed on master, so it will be a fairly substantial task to forward-port it for v0.4+. I'm going to re-title this issue to repurpose it as a task for that port.

@ches ches changed the title Storage support for Cassandra Forward-port Cassandra storage support for v0.4+ Jan 9, 2020
@stale
Copy link

stale bot commented Mar 29, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 29, 2020
@woop woop added the keep-open label Mar 29, 2020
@stale stale bot removed the wontfix This will not be worked on label Mar 29, 2020
@woop
Copy link
Member

woop commented Feb 8, 2021

Closing due to issue being stale.

@woop woop closed this as completed Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants