Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas 2.0 support #3709

Closed
0x26res opened this issue Aug 5, 2023 · 5 comments · Fixed by #3957
Closed

Pandas 2.0 support #3709

0x26res opened this issue Aug 5, 2023 · 5 comments · Fixed by #3957
Labels
kind/feature New feature or request

Comments

@0x26res
Copy link

0x26res commented Aug 5, 2023

Is your feature request related to a problem? Please describe.

I'm trying to install feast with pandas 2.0.3, but feast is pinned to pandas <2:

feast/setup.py

Line 55 in c75a01f

"pandas>=1.4.3,<2",

Describe the solution you'd like

Allow pandas >2. I'm not sure how much effort it will be, my experience upgrading has been simple, and provided there's a good test coverage of the pandas features being used by feast, it should be fine.

Describe alternatives you've considered

I could rollback my codebase to an older version of pandas but I'm using some of the new feature and rely on recent bug fixes.

Additional context

python3.9 -m venv --clear tmp
source tmp/bin/activate/
pip install pandas==2.0.3 feast==0.31.1

ERROR: Cannot install feast==0.31.1 and pandas==2.0.3 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested pandas==2.0.3
    feast 0.31.1 depends on pandas<2 and >=1.4.3


@0x26res 0x26res added the kind/feature New feature or request label Aug 5, 2023
@sudohainguyen
Copy link
Collaborator

I reopened my PR here

#3664

@sudohainguyen
Copy link
Collaborator

java_pr failed somehow 😢

@matthewarmand
Copy link

Is this considered a priority for Feast? We're attempting to use Feast but resolving the dependencies and downgrading Pandas so far to accommodate this library is problematic.

@ddl-joyce-zhao
Copy link

Hello,

The issue that blocked the PR #3664 to extend Pandas version support has been solved. Could you please reconsider this request? Thanks.

@sudohainguyen
Copy link
Collaborator

Great to know, thanks @ddl-joyce-zhao
I'm going to handle this soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
4 participants