Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online Store client does not map application errors #4481

Closed
tmihalac opened this issue Sep 3, 2024 · 0 comments · Fixed by #4488
Closed

Online Store client does not map application errors #4481

tmihalac opened this issue Sep 3, 2024 · 0 comments · Fixed by #4488

Comments

@tmihalac
Copy link
Contributor

tmihalac commented Sep 3, 2024

Expected Behavior

In a feast application that has a remote Online Store configured, when a feast client invokes an API on the Online Store that throws an error, the expectation is that the client will raises the same error that the online store threw

Current Behavior

When an error occurs a response with status code = 500 and error_message=Internal Server Error is returned from the server

Steps to reproduce

See Expected Behavior section.

Specifications

  • Version: 0.40.0
  • Platform: any
  • Subsystem: online store server

Possible Solution

The online store server can wrap the original exception in an error status message that the remote online store client can catch and translate into the original exception:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant