From 63344cfde721796d698a55b9a7f2da7762d897b2 Mon Sep 17 00:00:00 2001 From: Cody Lin Date: Thu, 9 Sep 2021 10:25:14 -0700 Subject: [PATCH] Move apply(dummy_entity) to apply time to ensure it persists in FeatureStore Signed-off-by: Cody Lin --- sdk/python/feast/feature_store.py | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/sdk/python/feast/feature_store.py b/sdk/python/feast/feature_store.py index 0a108c973a..a1bb2ae37b 100644 --- a/sdk/python/feast/feature_store.py +++ b/sdk/python/feast/feature_store.py @@ -100,12 +100,6 @@ def __init__( repo_path=self.repo_path, cache_ttl=timedelta(seconds=registry_config.cache_ttl_seconds), ) - DUMMY_ENTITY = Entity( - name=DUMMY_ENTITY_NAME, - join_key=DUMMY_ENTITY_ID, - value_type=ValueType.INT32, - ) - self.apply(DUMMY_ENTITY) @log_exceptions def version(self) -> str: @@ -412,6 +406,14 @@ def apply( ) + len(odfvs_to_update) != len(objects): raise ValueError("Unknown object type provided as part of apply() call") + # DUMMY_ENTITY is a placeholder entity used in entityless FeatureViews + DUMMY_ENTITY = Entity( + name=DUMMY_ENTITY_NAME, + join_key=DUMMY_ENTITY_ID, + value_type=ValueType.INT32, + ) + entities_to_update.append(DUMMY_ENTITY) + for view in views_to_update: self._registry.apply_feature_view(view, project=self.project, commit=False) for odfv in odfvs_to_update: