Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REGRESSION]: 4.8.0-4.20.7 args is not iterable error on initiation #520

Closed
FossPrime opened this issue Jul 19, 2019 · 3 comments
Closed

Comments

@FossPrime
Copy link
Contributor

FossPrime commented Jul 19, 2019

Steps to reproduce

Run this Ultra Simplified code:
https://codesandbox.io/s/fhc-bug-shared-7otk3

Another more complete demo with the issue on 4.8+:
https://codesandbox.io/s/feathers-hooks-common-test-9e0st

Expected behavior

Should add todo's just fine on 4.8.0+, not just 4.7.0

Change that caused the regression

v4.7.0...v4.8.0

Actual behavior

  • Console outputs TypeError: args is not iterable as long as 4.8.0+ is listed as a dependency.
  • Importing the module is no necessary to reproduce the issue.
  • @feathersjs/commons does not break the app. Indicating that we are violating a precondition.
  • client side support is completely broken... tests should be added.

System configuration

Module versions:
4.8.0 - 4.20.7
4.7.0 works fine

NodeJS version: 12

Operating System: linux

Browser Version: Chrome 75

Module Loader: webpack

Getting feathers-hooks-common to run on codesandbox makes debugging real apps MUCH easier.

@FossPrime FossPrime changed the title 4.8.0 args is not iterable error on initiation 4.8.0-4.20.7 args is not iterable error on initiation Jul 19, 2019
@FossPrime
Copy link
Contributor Author

Looks like the issue stems from the former feathers-commons, now known as @feathersjs/commons.
feathersjs-ecosystem/commons@v1.2.0...v1.4.0

// Converters from service method arguments to hook object properties
exports.converters = {
  find (args) {
    const [ params = {} ] = args;

    return { params };
  },
  create (args) {
    const [ data, params = {} ] = args;

    return { data, params };
  },
  get: convertGetOrRemove,
  remove: convertGetOrRemove,
  update: convertUpdateOrPatch,
  patch: convertUpdateOrPatch
};

@FossPrime
Copy link
Contributor Author

Updated the report with a simplified demo... This one depends just on memory, hooks-common and feathers, yet has the same issue.

https://codesandbox.io/s/fhc-bug-shared-7otk3

@FossPrime FossPrime changed the title 4.8.0-4.20.7 args is not iterable error on initiation Regression: 4.8.0-4.20.7 args is not iterable error on initiation Jul 22, 2019
@FossPrime FossPrime changed the title Regression: 4.8.0-4.20.7 args is not iterable error on initiation [REGRESSION]: 4.8.0-4.20.7 args is not iterable error on initiation Jul 22, 2019
@FossPrime
Copy link
Contributor Author

I can't begin to reproduce this outside of code sandbox :/ It works fine on glitch. May be a babel issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant