Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDE (VSCode) confused? #656

Closed
strarsis opened this issue Mar 5, 2022 · 1 comment · Fixed by #663
Closed

IDE (VSCode) confused? #656

strarsis opened this issue Mar 5, 2022 · 1 comment · Fixed by #663

Comments

@strarsis
Copy link

strarsis commented Mar 5, 2022

Steps to reproduce

  1. Ensure that the feathers-hooks-common is installed.
  2. Auto-import alterItems (VSCode IDE Quick fix ("blue lightbulb"))
  3. Note that the FeathersJS app doesn't start:
    Cannot find module 'feathers-hooks-common/types'

Expected behavior

The IDE shouldn't import from feathers-hooks-common/types but rather from feathers-hooks-common.

Actual behavior

The IDE imports from feathers-hooks-common/types.

System configuration

Module versions Probably this package / metadata.

NodeJS version: v16.14.0

Operating System: Ubuntu 20.04.4 LTS on WSL 2 on Windows 10 x64

Browser Version: Chrome 98.0.4758.102

React Native Version: (Not used)

Module Loader: vite (from example FeathersJS project)
@fratzinger fratzinger mentioned this issue May 10, 2022
Closed
@fratzinger fratzinger mentioned this issue May 21, 2022
Merged
@fratzinger
Copy link
Collaborator

We released a new typescript version of feathers-hooks-common. Please try updating npm i feathers-hooks-common@6 and try the import again. Please let me know if your issue is fixed then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@strarsis @fratzinger