Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] UI should disable auth if Feathr is deployed with RBAC set to off #924

Closed
1 of 4 tasks
blrchen opened this issue Dec 14, 2022 · 0 comments · Fixed by #925
Closed
1 of 4 tasks

[FR] UI should disable auth if Feathr is deployed with RBAC set to off #924

blrchen opened this issue Dec 14, 2022 · 0 comments · Fixed by #925
Labels
feature New feature or request ui

Comments

@blrchen
Copy link
Collaborator

blrchen commented Dec 14, 2022

Willingness to contribute

Yes. I can contribute a fix for this bug independently.

Feature Request Proposal

Right now, if user deploys deploys Feathr with RBAC disabled, there are still login prompts when user accesses web UI. The means the RBAC flag only works on server side but not on UI side. This causes many confusions.

A proposed change to improve UI experience is make UI respect rbacEnabled env setting set by deployment, only trigger login flow if this flag is true.

Motivation

What is the use case for this feature?

For users who is working on dev/test or evaluation poc, they would prefer to setup a sandbox environment without RBAC to get started quickly.

Details

No response

What component(s) does this feature request affect?

  • Python Client: This is the client users use to interact with most of our API. Mostly written in Python.
  • Computation Engine: The computation engine that execute the actual feature join and generation work. Mostly in Scala and Spark.
  • Feature Registry API: The frontend API layer supports SQL, Purview(Atlas) as storage. The API layer is in Python(FAST API)
  • Feature Registry Web UI: The Web UI for feature registry. Written in React
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request ui
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant