Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need an autosave feature so if Lizzie completely crashes, the game resumes from last input #140

Closed
bochen2027 opened this issue Apr 26, 2018 · 10 comments
Labels
enhancement New feature or request

Comments

@bochen2027
Copy link

bochen2027 commented Apr 26, 2018

Some people are already using this to play against strong pros and its frustrating when it crashes mid game...

We need an autosave feature so if Lizzie completely crashes, the game resumes from last input

Right now the only workaround is to save a sgf every few moves. Not good.

Many times the Leelaz.exe within Lizzie will exception out and crash mid game.

Lets do an autosave like how Word and etc does it please. Auto recovery too
it should save something to temp file/folder per move that is made as it is made so that a full recovery can be made in the event of an unexpected crash or shutdown

@featurecat
Copy link
Owner

what? Leela zero has never crashed for me. did you compile it yourself? I also use lizzie a lot so I've tested this quite a bit.

@bochen2027
Copy link
Author

bochen2027 commented Apr 26, 2018

image

This was not self compiled.

@bochen2027
Copy link
Author

image

@featurecat
Copy link
Owner

is it one you compiled yourself or the one with release?

@Ka-zam
Copy link
Contributor

Ka-zam commented Apr 26, 2018

I maintain a Win 64-bit build with Lizzie support that tracks next branch here:
https://github.com/Ka-zam/leela-zero/releases

It has never crashed for me since SMP and uct pointer fixes were pushed.

@aerisnju
Copy link
Contributor

I've never experienced such a crash, but one of my friends has. After my checking, his computer had only 8GB memories but two GPU cards installed. The memory for leelaz would be exhausted soon after analyzing for several minutes, especially when using a larger network file(e.g. 20b256f).
I suggested adding some memories and the crash frequency has been reduced significantly. So the amount of memory maybe one of the causes.

@AncalagonX
Copy link

AncalagonX commented May 3, 2018

We definitely need an auto-save function in Lizzie. Non-Lizzie related computer crashes (GPU overheat, driver crash, etc.) can cause the entire game to be lost. Things like this have happened several times to me, and I would greatly appreciate an auto-save feature no matter how simple its implementation.

@featurecat featurecat added the enhancement New feature or request label May 8, 2018
@baduk1
Copy link

baduk1 commented May 10, 2018

Yes, would be good. My lizzie crushes sometimes when I run ELF weights.

@bochen2027
Copy link
Author

Memory isn't the issue, I have more than 200GB of RAM and not even 10% was used when it crashes

@OlivierBlanvillain
Copy link
Contributor

I think we can considered this to be solved after #298. If there are still thinks to improve on top of that please make a new issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants