Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mouse to navigate in branch window #373

Open
phiming opened this issue Sep 29, 2018 · 7 comments
Open

Use mouse to navigate in branch window #373

phiming opened this issue Sep 29, 2018 · 7 comments

Comments

@phiming
Copy link

phiming commented Sep 29, 2018

This program is really wonderful, very nice, very powerful. Thanks to author and contributors!

I used it very often recently, but it's not very convenient when navigate to a position in the branch window by using keyboard, can I use mouse click to jump to a position? There is no such support officially, so I try to solve it myself.

I read code, clone code, modify code, add code.
Wow, IT WORKS!

And now, I can use mouse to navigate in branch window just like in Sabaki.
Anyone who are interested in this feature can download it from https://github.com/phiming/lizzie
I will commit it if there is no serious bug.

@zsalch
Copy link
Contributor

zsalch commented Sep 30, 2018

Good job!
I am also very interested in this feature. Looking forward ...

@phiming
Copy link
Author

phiming commented Sep 30, 2018

@zsalch

HI, I just find your interesting work, display SGF with variations, is related to this feature. So, I merge your next_dev branch to mine, and it works without any problem. GREAT! Thanks for your job

@zsalch
Copy link
Contributor

zsalch commented Oct 4, 2018

@phiming
Thanks for your great job.
Yes, I also want to implement the mouse click function, now it seems that we have a good implementation, I will test it as soon as possible.

And I hope do more related features, maybe you have better method or suggestion:

  1. Highlight the node of the variation when mouse over it.
  2. Display a difference color when node has a comment of sgf.
  3. More shortcut keys to switch between variations.

@phiming
Copy link
Author

phiming commented Oct 4, 2018

@zsalch
Thanks for your good suggestions.
In fact, I was thinking how to use mouse and variation window better for some time.

Tonight, I wrote some code to test one of my ideas, using different color to indicate move blunder, like, red means serious blunder, and yellow means questionable blunder. I will open an issue to get more advice.

About your 3 sugguestion,

  1. It's possible, but needs more computing, and not very useful though it looks cool.
  2. Now, I use different color to indicate blunder, so, maybe we can use another shape to imply there is comments here.
  3. There are some shortcut keys, like, shift+up, shift+down, shift + mouse right button, shift+mouse wheel, the last two are under PR. I think it's enough, but we need tell others how to use it. I suggest to reduce font size of quick HELP to give more information for beginners. When they hold ctrl-x, they will learn more tips

@zsalch
Copy link
Contributor

zsalch commented Oct 5, 2018

  1. Yes, so before I had a better solution, I have not started to change it.
    Maybe using shape is easier to implement, but it will also bring more rendering performance.

  2. I see.It looks good.

  3. Some people want to jump to a special node faster, such as those with comments, so can quickly see all the comments.

@phiming
Copy link
Author

phiming commented Oct 6, 2018

@zsalch
1, Although it needs more computing, maybe it's worthy to have it. Sabaki has such feature, and I think when the mouse is over one node, even the comments of this node will be displayed, that's very cool. You may try it if you are free, for saving time, you can call inVariationTree(mouseX, mouseY) to get the node to highlighten
2, I may use concentric circles to indicate comments, it's simple implementation but enough. I need API to know this node has comments.
3, How about using control or alt key combined with mouse to jump ?

@zsalch
Copy link
Contributor

zsalch commented Oct 6, 2018

About 3: Should be through keyboard shortcuts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants