Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to close submenu accordions on mobile menu #2172

Closed
1 task
johnnyporkchops opened this issue Jul 9, 2018 · 9 comments
Closed
1 task

Allow users to close submenu accordions on mobile menu #2172

johnnyporkchops opened this issue Jul 9, 2018 · 9 comments

Comments

@johnnyporkchops
Copy link
Contributor

johnnyporkchops commented Jul 9, 2018

What we're after: The mega menus use an accordion interaction in mobile view, when the menu is accessible via the hamburger icon. Currently a plus sign turns into a minus sign when one clicks to open the menu. However the minus symbol to close the accordion does not work. In order to improve the usability of the mobile menu, we need to make it so that when a user clicks the icon the menu is properly closed.

Beyond that, following U.S. design principles, we should also enable the entire row, so that selecting anywhere on that header, a user can successfully close the accordion.

Completion criteria:

  • Make the entire submenu header/bar clickable to that users can select anywhere on that row to close the accordion

mega_ux

@JonellaCulmer
Copy link
Contributor

@johnnyporkchops Is it possible to make it so the minus signs can close an accordion? When we use the accordion feature on other parts of the site, such as on data tables, selecting the minus sign does close those accordions. I think I'd prefer that that functionality be consistently applied in the mobile menu as well.

@johnnyporkchops
Copy link
Contributor Author

@JonellaCulmer
Copy link
Contributor

That's great guidance you shared! So instead of it just being the icons, we should make it so that clicking that entire bar would either open or close the accordion, but I still think the icons should remain in place and not disappear.

@johnnyporkchops
Copy link
Contributor Author

@JonellaCulmer, I agree with your comments above. Lets pair on this to groom this issue more and determine how much of a lift it will be.

@JonellaCulmer
Copy link
Contributor

@johnnyporkchops Great! I'll add it to 6.5 work so we don't lose track of it.

@AmyKort
Copy link

AmyKort commented Jul 16, 2018

@JonellaCulmer can you take a crack at updating this ticket?

@JonellaCulmer JonellaCulmer changed the title UX of mobile menu accordion is misleading Allow users to close individual accordions submenus in mobile menu Jul 17, 2018
@JonellaCulmer JonellaCulmer changed the title Allow users to close individual accordions submenus in mobile menu Allow users to close submenu accordions on mobile menu Jul 17, 2018
@PaulClark2 PaulClark2 modified the milestones: Sprint 6.5, Sprint 6.6 Jul 24, 2018
@JonellaCulmer JonellaCulmer removed this from the Sprint 6.6 milestone Aug 31, 2018
@lbeaufort
Copy link
Member

@johnnyporkchops I can't reproduce this issue, can you?

@JonellaCulmer
Copy link
Contributor

I can't either, but it reminded me of another problem I found.

#3313

@patphongs
Copy link
Member

I am able to collapse the accordions on mobile. I will close this ticket, we'll re-prioritize #3313 somewhere to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants