-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to close submenu accordions on mobile menu #2172
Comments
@johnnyporkchops Is it possible to make it so the minus signs can close an accordion? When we use the accordion feature on other parts of the site, such as on data tables, selecting the minus sign does close those accordions. I think I'd prefer that that functionality be consistently applied in the mobile menu as well. |
USWDS Accordion: |
That's great guidance you shared! So instead of it just being the icons, we should make it so that clicking that entire bar would either open or close the accordion, but I still think the icons should remain in place and not disappear. |
@JonellaCulmer, I agree with your comments above. Lets pair on this to groom this issue more and determine how much of a lift it will be. |
@johnnyporkchops Great! I'll add it to 6.5 work so we don't lose track of it. |
@JonellaCulmer can you take a crack at updating this ticket? |
@johnnyporkchops I can't reproduce this issue, can you? |
I can't either, but it reminded me of another problem I found. |
I am able to collapse the accordions on mobile. I will close this ticket, we'll re-prioritize #3313 somewhere to fix it. |
What we're after: The mega menus use an accordion interaction in mobile view, when the menu is accessible via the hamburger icon. Currently a plus sign turns into a minus sign when one clicks to open the menu. However the minus symbol to close the accordion does not work. In order to improve the usability of the mobile menu, we need to make it so that when a user clicks the icon the menu is properly closed.
Beyond that, following U.S. design principles, we should also enable the entire row, so that selecting anywhere on that header, a user can successfully close the accordion.
Completion criteria:
The text was updated successfully, but these errors were encountered: