Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

So that the selected state is easier to identify, update style on radio button pattern #2950

Closed
2 tasks done
Tracked by #140
JonellaCulmer opened this issue Jun 6, 2019 · 3 comments · Fixed by #3014
Closed
2 tasks done
Tracked by #140
Assignees
Milestone

Comments

@JonellaCulmer
Copy link
Contributor

JonellaCulmer commented Jun 6, 2019

@jenniferthibault commented on Thu Nov 30 2017

The current flat style of the radio buttons makes it challenging to distinguish which option is selected visually. This proposed change creates an outline around the filled/selected option to reinforce the difference. The change is only to the selected state circular fill

screen shot 2017-11-30 at 9 55 29 am

Completion criteria

  • Create an outline around the filled/selected radio button
  • Open a ticket to update pattern library
[type=radio]:checked+label::before {
       box-shadow: 0 0 0 2px #fff inset
@johnnyporkchops
Copy link
Contributor

@jonella, do you think we should make a followup issue to make this a toggle? This AO filter is the only place on the site that we use radio buttons. Everywhere else we use toggles, which are actually just radio buttons under the hood (in the underlying code). The user is actually interacting with radio buttons that are hidden, and the labels create the button that registers clicks.
radio_to_toggles_AO-search

@JonellaCulmer
Copy link
Contributor Author

@johnnyporkchops Excellent point. Maybe a future ticket to explore changing the filter and what that would mean. The toggle tends to mean more that something is one or off but essentially they do function the same way.

@johnnyporkchops
Copy link
Contributor

johnnyporkchops commented Jul 8, 2019

@JonellaCulmer , I have aleady done a test and switching it to a toggle is fairly simple change. The AO React app was kind of built separately from all of the other datatables, so that may be why it has this one-off radio button filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants