Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add active/terminated status to /names/committees/ #4270

Closed
2 tasks
JonellaCulmer opened this issue Mar 25, 2020 · 1 comment
Closed
2 tasks

Add active/terminated status to /names/committees/ #4270

JonellaCulmer opened this issue Mar 25, 2020 · 1 comment
Assignees
Milestone

Comments

@JonellaCulmer
Copy link
Contributor

JonellaCulmer commented Mar 25, 2020

What we're after:
As part of our work to include a status indicator for all committees, we want to also add status to the global search, so users can see the status at a quick glance. When using the autosuggest for committee lookup, users want to quickly get results and be able to distinguish between active and terminated committees.

Here speed matters most, more than having api-user friendly data. /names/candidates/ is designed for the auto-suggest and doesn't provide any other data currently, so it's ok to make the abstraction from filing frequency to is_active true/false in the name of performance.

Related issues

Completion criteria

  • Add is_active to /names/committees/ endpoint

Helpful chart:

is_active filing_frequency filing frequency description
True Q Quarterly filer
True M Monthly filer
False T Terminated
False A Administratively terminated
  • Double-check that this doesn't slow down the search performance

Tech steps or considerations (optional)

This comment from the design issue: fecgov/fec-cms#3325 (comment)

Update ofec_committee_fulltext_mv to have is_active based on filing_frequency and bring those changes forward to the model/endpoint.

Design

Screen Shot 2020-03-11 at 9 36 43 AM

@JonellaCulmer JonellaCulmer transferred this issue from fecgov/fec-cms Apr 1, 2020
@JonellaCulmer JonellaCulmer changed the title Test the impact to results rate of return for global search if status indicator is added Test the impact to rate of return for global search results if status indicator is added Apr 1, 2020
@lbeaufort lbeaufort changed the title Test the impact to rate of return for global search results if status indicator is added Add filing frequency to /names/committees/ Apr 1, 2020
@lbeaufort lbeaufort changed the title Add filing frequency to /names/committees/ Add active/terminated status to /names/committees/ Apr 1, 2020
@JonellaCulmer JonellaCulmer added this to the Sprint 12.2 milestone Apr 15, 2020
@hcaofec
Copy link
Contributor

hcaofec commented May 13, 2020

PR is merged, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants