Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fedmsg-tail pretty args not pretty at all #429

Open
glensc opened this issue Jun 21, 2017 · 1 comment
Open

fedmsg-tail pretty args not pretty at all #429

glensc opened this issue Jun 21, 2017 · 1 comment

Comments

@glensc
Copy link
Contributor

glensc commented Jun 21, 2017

  --pretty              Pretty print the JSON messages.
  --really-pretty       Extra-pretty print the JSON messages.
  1. --pretty prints output in Python format, uncolored. prefixed with python log prefix
  2. --really-pretty prints output in json, colored. when output directed to file, it's still with ansi escapes

this all is not intuitive, neither descriptive.

proposal:
deprecate them both, add --json, --python options (or --format=json, --format=python), for --json detect that output is not terminal and omit colors.

@jeremycline
Copy link
Member

We can probably fix this as part of #424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants