Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app crash when trying to use picture-in-picture mode #797

Closed
cosven opened this issue Feb 16, 2024 · 1 comment
Closed

app crash when trying to use picture-in-picture mode #797

cosven opened this issue Feb 16, 2024 · 1 comment
Labels

Comments

@cosven
Copy link
Member

cosven commented Feb 16, 2024

Describe the bug
app crash when trying to use picture-in-picture mode

To Reproduce

  1. watch a video and click '画中画' button

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots

Desktop:

  • Wayland

possible root cause

Maybe mpv video output should be set to nil before it's QOpenGLWidget changes parent.

@contextmanager
def change_parent(self):
self._parent_is_changing = True
self._before_change_mpv_widget_parent()
yield
self._after_change_mpv_widget_parent()
self._parent_is_changing = False

@cosven cosven added the bug label Feb 16, 2024
@cosven
Copy link
Member Author

cosven commented Feb 18, 2024

should be fixed by #798

@cosven cosven closed this as completed Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant