Optimize for Sysbox

[felipecrs]

With Sysbox, there is no need for the dind hack.

[felipecrs]

Lines I can change when using Sysbox:

docker-images/devcontainer/rootfs/etc/s6-overlay/s6-rc.d/dind/run

Line 7 in 28a99ee

bash -c 'sleep 0.5s && exec dind dockerd'

- exec dind dockerd
+ exec dockerd

I can also probably remove these 2 files at initialization:

docker-images/devcontainer/scripts/prepare_image.sh

Lines 114 to 115 in 28a99ee

	echo 'dockremap:165536:65536' | tee -a /etc/subuid
	echo 'dockremap:165536:65536' | tee -a /etc/subgid

With rm -f /etc/subuid /etc/subgid on entrypoint.sh.

[felipecrs]

@ctalledo, I was waiting to be able to run sysbox myself to verify whether sysbox-runc would inject any environment variable to make it easy for me to detect whether the container is running with sysbox or not, but there's no extra variable.

Do you have any idea on whether this can be accomplished? (without having to mount the docker socket and inspecting the container on host for the runtime).

[ctalledo]

Hi @felipecrs,

I was waiting to be able to run sysbox myself to verify whether sysbox-runc would inject any environment variable to make it easy for me to detect whether the container is running with sysbox or not, but there's no extra variable.

Yes I think in general we avoid inserting env variables into the container because we want it to resemble a clean Linux host environment as much as possible.

One easy way to detect if the container is running with Sysbox is to look for sysboxfs in the container mounts (e.g., mount | grep sysboxfs). Would this do or do you need a more formal method?

[felipecrs]

That's sufficient for sure. Thank you very much.