Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Event Options: Data Types #52

Open
Sineos opened this issue Aug 13, 2021 · 4 comments
Open

[FR] Event Options: Data Types #52

Sineos opened this issue Aug 13, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@Sineos
Copy link

Sineos commented Aug 13, 2021

Me again 😇
It would be great if one can pass the data type on the event values. Currently only string is supported.

grafik

Again, many thanks 😃

@fellinga
Copy link
Owner

fellinga commented Aug 14, 2021

Hi,

yes the input field just takes a string value, but the node does check the value before it saves new timers - it will either remain a string, or gets converted to a number or boolean value. Are you missing anything specific?

Edit: Did a quick code review, seems that there is an issue with converting zero. I am gonna take a look at that later today.
Edit2: v1.15.2 now fixes the conversion of "0" to zero.

@Sineos
Copy link
Author

Sineos commented Aug 14, 2021

I have two use cases where I would need boolean in one and a flow-context variable in the other.
Of course, it is all about "user comfort" since you can work around this with switch / change nodes. Also it is a bit my style to make sure in my flows to use the data types as they are meant to be and not the "universal" javascript string.

Maybe more or less "borrowing" the block from the injection node?
grafik

@fellinga
Copy link
Owner

Well user comfort is also to enter something, without thinking about data types at all, and still get the correct data type.

So the thing that is currently missing for you would be to send "flow." or "global." variables?

@Sineos
Copy link
Author

Sineos commented Aug 14, 2021

I would appreciate following types:

  • string
  • number
  • boolean
  • flow.
  • global.

Thanks 😃

@fellinga fellinga added question Further information is requested enhancement New feature or request and removed question Further information is requested labels Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants