Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to update dependency on ember-get-config to 0.3.0 #298

Closed
havremunken opened this issue Mar 2, 2021 · 3 comments · Fixed by #299
Closed

Request to update dependency on ember-get-config to 0.3.0 #298

havremunken opened this issue Mar 2, 2021 · 3 comments · Fixed by #299
Assignees

Comments

@havremunken
Copy link

Hi there,

My ember-dependency-lint is angry and it is because this is the last library I use that uses the older 0.2.4 version.

Could I please request an update that uses 0.3.0, like many other packages do?

Thanks!

@fenichelar
Copy link
Owner

@havremunken Are you able to test https://github.com/fenichelar/ember-simple-auth-token#master?

@havremunken
Copy link
Author

@fenichelar I replaced the official ember-simple-auth-token with your version, started the server, and I could log in / log out etc. as before. Seems to be working perfectly!

The dependency linter is also satisfied.

I have not been able to test the library in a deeper sense, because of some issues with running headless Chrome tests in Debian running under WSL2 on Windows, but everything I have been able to test, has passed.

I am keeping the branch in which I tested this around for a while if you have anything more concrete you want me to test. :)

Thanks for the quick response!

@fenichelar
Copy link
Owner

@havremunken Thanks!

Once @jpadilla approves, I'll release v5.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants