Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spin-v2.4.3-macos-amd64.tar.gz contains the wrong architecture #2502

Closed
jandubois opened this issue May 9, 2024 · 4 comments
Closed

spin-v2.4.3-macos-amd64.tar.gz contains the wrong architecture #2502

jandubois opened this issue May 9, 2024 · 4 comments

Comments

@jandubois
Copy link

I noticed that the amd64 download for 2.4.3 actually contains an arm64 binary:

$ tar xvfz spin-v2.4.3-macos-amd64.tar.gz spin
x spin
$ file spin
spin: Mach-O 64-bit executable arm64

The 2.5.0 binary has the correct architecture:

$ tar xvfz spin-v2.5.0-macos-amd64.tar.gz spin
x spin
$ file spin
spin: Mach-O 64-bit executable x86_64
@vdice
Copy link
Member

vdice commented May 9, 2024

Thank you for notifying @jandubois. It looks like this is due to the release workflow on the v2.4 branch (and thus the v2.4.3 tag) still using macos-latest for the build step and had been assuming it was still amd64-based, while GitHub has since transitioned this runner to be based on an M1/arm64 Mac. (And, indeed, on main and v2.5/v2.5.0 we have since updated to explicitly use macos-13 for amd64 builds.)

We'll either have to update the archive on the release in-place or perhaps patch the workflow (to use macos-13) on the v2.4 branch and cut a 2.4.4 release... I'll work with @kate-goldenring on this asap.

@jandubois
Copy link
Author

Depending on how long it will take to fix, it may be a good idea to put a warning on top of the release notes to let other users know that this is a known issue?

@vdice
Copy link
Member

vdice commented May 9, 2024

@jandubois the spin-v2.4.3-macos-amd64.tar.gz artifact has now been updated on the v2.4.3 release.

@jandubois
Copy link
Author

@jandubois the spin-v2.4.3-macos-amd64.tar.gz artifact has now been updated on the v2.4.3 release.

Too late, I've moved on to 2.5.0 now 😄

j/k, I've confirmed that the file contains an Intel binary now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants