Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent units of bounding box yaws #10

Open
RM-Costa opened this issue Aug 11, 2020 · 3 comments
Open

Inconsistent units of bounding box yaws #10

RM-Costa opened this issue Aug 11, 2020 · 3 comments

Comments

@RM-Costa
Copy link

In config.py, the yaws are written in radians, but in point_pillars_test.py they're in degrees.

Is this a bug or am I missing something ?

@tyagi-iiitv
Copy link

This is the updated version of this repo: https://github.com/tyagi-iiitv/PointPillars.

@RM-Costa
Copy link
Author

This is the updated version of this repo: https://github.com/tyagi-iiitv/PointPillars.

Thanks for the answer, but I still see the same issue in your fork.
In config.py the anchor boxes orientation is in radians, but in point_pillars_test.py the yaws are in degrees.
These values are used in the IoU computation, which uses std::cos and std::sin operations, so the units should be all in radians for the code to work properly.

@tyagi-iiitv
Copy link

I've added this as an issue on my repo, I'll verify and work on it. In the meantime, if you want to submit a PR to my repo, go ahead with that. Anyway, I'll let you know when this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants