Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Add CSRF Token #91

Open
abisz opened this issue Aug 25, 2016 · 4 comments
Open

[Security] Add CSRF Token #91

abisz opened this issue Aug 25, 2016 · 4 comments

Comments

@abisz
Copy link
Contributor

abisz commented Aug 25, 2016

Secure all relevant routes with csrf token

@abisz abisz added the security label Aug 25, 2016
@miclaus
Copy link
Member

miclaus commented Aug 26, 2016

This is indeed very important ! I actually disabled the CSRF security provider, as far as I can remember, since w̷h̷e̷n̷ ̷u̷s̷i̷n̷g̷ ̷m̷o̷b̷i̷l̷e̷ the CSRF Token must be explicitly sent as a Request-Header field.

Here is the documentation on Laravel 4.2 Route Protection:
https://laravel.com/docs/4.2/security#protecting-routes

@abisz
Copy link
Contributor Author

abisz commented Aug 26, 2016

how can it be different on mobile?

@miclaus
Copy link
Member

miclaus commented Aug 26, 2016

@abisz ahm, actually it's not different on mobile, just when we do "AJAX calls"

@miclaus
Copy link
Member

miclaus commented Aug 26, 2016

... but pretty much all calls we do are "in the background, so we need to set the CSRF token, but try it to see whether it is actually needed to set the token manually or sent by POST request, i might be confusing different Laravel versions :o

@miclaus miclaus changed the title Add CSRF Token [Security] Add CSRF Token Dec 21, 2016
@miclaus miclaus modified the milestone: v1.3 Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants