Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gadgets: Simplify by Factoring out the DataContainer??? #38

Open
chalkie666 opened this issue Aug 24, 2015 · 0 comments
Open

Gadgets: Simplify by Factoring out the DataContainer??? #38

chalkie666 opened this issue Aug 24, 2015 · 0 comments
Milestone

Comments

@chalkie666
Copy link
Collaborator

Why? Because it is complex and opaque making dev harder, especially for developers who are new to this plugin?

idea from Dscho - run through the de-Torvalds filter:

The DataContainer is cute, if perhaps rather over-engineered.
The makes it hard to sit a new developer (or Dan White) in front of the Coloc2 source code and figure out how its working.
Example: its hard to figure out where the color map is set.
Example: Due to the many indirections in the container, it is pretty tricky debug into it.
(Dan wonders what "indirection" is, and has to check on Wikipedia...)

A solution might be to:
First, make everything explicit (again).
Remove the DataContainer and replace it with direct data flows that are easier to follow and understand, building on the nice ResultHandler idea.
The SingleWindowDisplayand pdf outputter implementations of ResultsHandler are two completely separate things... and should do their own thing, but use the same data.

@etadobson etadobson added this to the m1 milestone Oct 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants