feat: implemented hideDotfiles feature in the backend #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o1egl
requested changes
Nov 17, 2020
|
The path provided to the function are relative paths with directory prefixes, so `strings.HasPrefix("/a/b/c/.docker.json", "/.”)` does not work and we’d need the base name. That’s just an extra import and sort of out of line with the rest of the rules because they’re all Regex, but if you wanna do let this way, I don’t mind.
…On 18 Nov 2020, 5:22 PM +0800, Oleg Lobanov ***@***.***>, wrote:
@o1egl commented on this pull request.
In rules/rules.go:
> +var MatchHidden = Rule{
+ Regex: true,
+ Regexp: &Regexp{Raw: `\/\..*$`},
+}
\/\..*$ and strings.HasPrefix("/.") are equal. So I don't understand why it shouldn't work. Better would be to get the base name and then check if it starts from .
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Prefix based comparison is much faster than the regexp. |
Use `strings.HasPrefix` to avoid panic on empty string. Co-authored-by: Oleg Lobanov <[email protected]>
test naming convention Co-authored-by: Oleg Lobanov <[email protected]>
o1egl
reviewed
Nov 18, 2020
Co-authored-by: Oleg Lobanov <[email protected]>
|
Any more changes needed? |
o1egl
approved these changes
Nov 20, 2020
mitsukileung
added a commit
to mitsukileung/filebrowser
that referenced
this pull request
Nov 21, 2020
feat: add hide dotfiles param (filebrowser#1148)
|
@NieTiger @o1egl Is this a configurable option when launching in a docker container? I looked in the source and I didn't see anything that would suggest it, but I wanted to ask to confirm. Didn't see it in the documentation as well. I am looking for dotfiles to be hidden by default. Appreciate the help! Thanks. |
|
@smithzss this param is only available in the UI. |
|
@o1egl would you consider a PR implementing a flag for this param in the Cmd ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1084.
Per @o1egl, I've rewritten my previous PR (#1085) to move the filtering logic to the backend.
By default the
hideDotfilesoptions is turned off, and it can be turned on in profile settings.