Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add height to derived_gas_outputs #251

Closed
hsanjuan opened this issue Nov 19, 2020 · 3 comments
Closed

Add height to derived_gas_outputs #251

hsanjuan opened this issue Nov 19, 2020 · 3 comments
Labels
status/discussion Issue is under discussion

Comments

@hsanjuan
Copy link
Contributor

Description

Adding height should allow optimized JOIN with block_headers (current it either joins by state_root or by joining with intermediary tables like messages). It is slow.

Acceptance criteria

Height column exists and populated (?).

Where to begin

Gas Outputs model.
@hsanjuan
Copy link
Contributor Author

Maybe this is a bad idea: to discuss

@hsanjuan
Copy link
Contributor Author

Also, it might also be good to include the dst actor code directly.

@frrist frrist added the status/discussion Issue is under discussion label Dec 2, 2020
@iand
Copy link
Contributor

iand commented Dec 8, 2020

Fixed in #270

@iand iand closed this as completed Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/discussion Issue is under discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iand @hsanjuan @frrist