Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove markets API calls from lotus-miner info #10362

Closed
6 of 15 tasks
Tracked by #10338
dirkmc opened this issue Feb 28, 2023 · 1 comment · Fixed by #10364
Closed
6 of 15 tasks
Tracked by #10338

Remove markets API calls from lotus-miner info #10362

dirkmc opened this issue Feb 28, 2023 · 1 comment · Fixed by #10364
Labels
kind/enhancement Kind: Enhancement

Comments

@dirkmc
Copy link
Contributor

dirkmc commented Feb 28, 2023

Checklist

  • This is not a new feature or an enhancement to the Filecoin protocol. If it is, please open an FIP issue.
  • This is not a new feature request. If it is, please file a feature request instead.
  • This is not brainstorming ideas. If you have an idea you'd like to discuss, please open a new discussion on the lotus forum and select the category as Ideas.
  • I have a specific, actionable, and well motivated improvement to propose.

Lotus component

  • lotus daemon - chain sync
  • lotus miner - mining and block production
  • lotus miner/worker - sealing
  • lotus miner - proving(WindowPoSt)
  • lotus miner/market - storage deal
  • lotus miner/market - retrieval deal
  • lotus miner/market - data transfer
  • lotus client
  • lotus JSON-RPC API
  • lotus message management (mpool)
  • Other

Improvement Suggestion

Currently lotus-miner info outputs information about the miner, and also information about storage and retrieval deals.
In order to get the deal information it needs to retrieve all storage deals and all retrieval deals ever made by the miner.
As markets functionality is moving over to the boost project, we propose removing the deal information from the output of lotus-miner info, so that no calls need be made to the markets subsystem.

@rjan90
Copy link
Contributor

rjan90 commented Feb 28, 2023

Agreed! I propose that we try to get this into the v1.21.0 feature release, targeted for March 7th.

@rjan90 rjan90 added this to the v1.21.0 milestone Feb 28, 2023
@jacobheun jacobheun added this to Boost Feb 28, 2023
@jacobheun jacobheun moved this to In Progress in Boost Feb 28, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Boost Mar 1, 2023
@rjan90 rjan90 moved this to ✅ Done in Lotus-Miner-V2 Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Kind: Enhancement
Projects
Status: Done
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants