-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark nv23 migration #12128
Comments
@jennijuju : below are some questions for a newbie. I'm fine to get a verbal brain dump if that is quicker for you (and I can then expand the text). Here are the questions I have:
Does that mean updating lotus to use the latest go-state-types release (as part of updating lotus dependencies)
Is there an example PR of this in the past to refer to?
Do we have docs on this (e.g., sample commands that have been run in the past)? It's fine if not, but I would want to capture this. My thinking is we need to capture what we do manually today so we can have multiple people do it and potentially automate.
What are the commands to run?
Do we have more guidance on what "fast enough" means?
What network do we do this on, and what hardware?
Does this mean that there should be no degradation when the migration is happening?
Where does this get proposed/discussed? (Is there an example post from the past?) General questions:
|
the basic one is a part of the go state type upgrade skeleton & different FIP may have different needs. we have done this for nv23
not docs it a cli:
for this upgrade i expect it to be less than 5 sec if its not .. 1sec lolol. for more complicated migration we would like to be within 10-20sec range for the final migration, cuz anything beyond that is v close to block time -> miner may lose block or network wise we have null blocks
mainnet - cuz it has the most states. yah whatever machine folks are using to sync the chain is sufficient for this. (some maybe slower some maybe faster, but its a part of the benchmark gathering imho)
for this one, yes.
can do one as soon as we have the most code needed; def should do one before final calib release to catch any state invariant mismatch that may point out bugs |
Running the migration benchmark on a lower powered machine. (Spec: Intel(R) Xeon(R) Silver 4114 CPU @ 2.20GHz, 128GiB RAM, SSD) In offline mode following the tutorial here:
Max memory usage observed during the migration was 23GiB. In online mode following the tutorial here: Pre-Migration in "online-mode" on the same hardware as mentioned above:
And the actual migration in "online-mode":
Max memory usage observed during the migration was 30GiB. |
Updated numbers/memory requirements in the changelog here: 33d0861 I have moved the |
Closing as completed. |
Get an archival node to run the migration.(Moved to the master tracking doc)The text was updated successfully, but these errors were encountered: