Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dangling reorgWorker after snapshot import #4428

Closed
schomatis opened this issue Oct 16, 2020 · 1 comment · Fixed by #4872
Closed

dangling reorgWorker after snapshot import #4428

schomatis opened this issue Oct 16, 2020 · 1 comment · Fixed by #4872
Labels
area/chain Area: Chain

Comments

@schomatis
Copy link
Contributor

lotus/chain/store/store.go

Line 190 in 151577f

cs.reorgCh = cs.reorgWorker(context.TODO(), []ReorgNotifee{hcnf, hcmetric})

Normally not an issue because the repo/store is not closed until the node stops but when importing we open/close the repo and the dangling thread fails with datastore closed error.
@schomatis schomatis added the area/chain Area: Chain label Oct 16, 2020
@schomatis schomatis mentioned this issue Nov 13, 2020
Closed
@raulk
Copy link
Member

raulk commented Nov 16, 2020

Oh, I actually noticed this independently and fixed it in #4872.

@raulk raulk mentioned this issue Nov 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/chain Area: Chain
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix badger double open on daemon --import-snapshot; chainstore lifecycle filecoin-project/lotus
2 participants
@raulk @schomatis