Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give an option to get a more precise termination penalty with pending termination penalty excluded #4667

Closed
jennijuju opened this issue Oct 30, 2020 · 1 comment
Labels
area/ux Area: UX kind/enhancement Kind: Enhancement P3 P3: Might get resolved

Comments

@jennijuju
Copy link
Member

jennijuju commented Oct 30, 2020

Termination sectors are triggered in a cron job and we patch them in several jobs when there is too may sector termination in one request. This means, with a new termination sector request, there might be some pending termination jobs left from the previous executed jobs that will be executed in this run as well.

The current lotus-shed sectors termination-estimation takes a list of sectors and calls terminate sectors and get the penalty without excluding the pending sectors. This may make the estimation a bit off if the miner has a lot of sectors termination in progress.

What we can do here is add an option to the cmd for getting a more accurate estimation. And to do so, we can sweep back from the current chain head until the tipset that miner does not have pending termination, then get the penalty for the sector termination requested.

@jennijuju
Copy link
Member Author

related: #4617 (comment)

@jennijuju jennijuju changed the title Give an option to get a more precise termination penalty Give an option to get a more precise termination penalty with pending termination penalty excluded Oct 30, 2020
@arajasek arajasek added the P3 P3: Might get resolved label Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ux Area: UX kind/enhancement Kind: Enhancement P3 P3: Might get resolved
Projects
None yet
Development

No branches or pull requests

2 participants