Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not set-owner to a Ledger address, ERROR: mpool push: failed to sign message: Unexpected method #5127

Closed
ohJohanZ opened this issue Dec 5, 2020 · 18 comments

Comments

@ohJohanZ
Copy link

ohJohanZ commented Dec 5, 2020

Describe the bug
Can not set-owner to a Ledger address, sign error with Ledger-Nano-X.

To Reproduce
Steps to reproduce the behavior:
$ lotus wallet new secp256k1-ledger
f1xxxxxxxxxxxxxxxxxxxxxxxxxxx

$ lotus-miner actor set-owner --really-do-it f1xxxxxxxxxxxxxxxxxxxxxxxxxxx
Propose Message CID: baaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
ERROR: mpool push: failed to sign message: Unexpected method

@hyunmoon
Copy link

hyunmoon commented Dec 5, 2020

@Kubuxu
Copy link
Contributor

Kubuxu commented Dec 7, 2020

You need to enable Expert Mode on Ledger in Filecoin app.

@hyunmoon
Copy link

hyunmoon commented Dec 8, 2020

I did enable Export Mode per Magik6k's suggestion.
But I'll try it one more time just in case and report back.

@ohJohanZ
Copy link
Author

ohJohanZ commented Dec 11, 2020

You need to enable Expert Mode on Ledger in Filecoin app.

Not working

@hyunmoon
Copy link

hyunmoon commented Jan 5, 2021

Yes, not working even with export mode enabled.

@Stebalien
Copy link
Member

@hyunmoon by "not working", do you mean that it failed with the same error, or a different error.

@ohJohanZ's initial issue was definitely not enabling Expert Mode. Unfortunately, changing the owner key requires two messages:

  1. A message from the original owner to propose the change.
  2. A message from the new owner to accept the change.

This ensures that target owner actually works.

Unfortunately, lotus attempts to send this second confirmation message from the new owner address, which doesn't work because it's a multisig address. This command needs to be fixed to support multisig confirmations.

@hyunmoon
Copy link

hyunmoon commented Jan 5, 2021

@Stebalien Failed with the same error. It failed to process the second confirmation message.

@hyunmoon
Copy link

hyunmoon commented Jan 5, 2021

Changing the owner to a normal (non-Ledger) SECP key worked.

@hyunmoon
Copy link

hyunmoon commented Jan 5, 2021

But Ledger key isn't a multi-sig key, is it?
My suspicion is the Ledger filecoin app has trouble signing the change owner address message.
Am I correct?

@jennijuju
Copy link
Member

But Ledger key isn't a multi-sig key, is it?
My suspicion is the Ledger filecoin app has trouble signing the change owner address message.
Am I correct?

It’s not.

@Stebalien
Copy link
Member

Ah, I'm sorry. I'm getting my issues confused (this one is about the ledger, not the multisig...).

This is a bug in the ledger code. For some reason, ledger only allows up to method number 7 in "expert" mode. It needs to allow all methods.

Zondax/ledger-filecoin#65

@cwhiggins
Copy link

Is there an ETA on when Ledger will support owner address?

@arajasek
Copy link
Contributor

Not really a Lotus issue, but let's keep this issue around to track. This or some version of it needs to land.

@oricot
Copy link

oricot commented May 30, 2021

I have a similar problem. My owner is on secp256k1-ledger wallet. I received the same error when I try do withdraw or set a different owner. Should I open a new issue?

@Araquiel
Copy link

try to change owner to ledger wallet and have a same error.
did you found solution?

@oricot
Copy link

oricot commented Jan 17, 2022

I m able to withdraw but I don't think their is a solution to change the owner. I didn't try for a while

@Zboi04
Copy link

Zboi04 commented Feb 11, 2022

I just tried making my owner address a secp256k1-ledger as well, and I'm getting the same error as ohJohanZ. I'm surprised this issue has been open for this long.

@rjan90
Copy link
Contributor

rjan90 commented May 3, 2022

Hey!

I changed the owner-address of a storage provider to a Ledger-backed wallet (secp256k1-ledger) successfully on Lotus version 1.15.1-dev+2k+git.4c94ae45d today. So closing this issue as it seems to have been fixed.

I just followed the regular steps documented in the docs. You can see the repro here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests