Dagstore Migration Causes Invalid Characters In Log

[TippyFlitsUK]

Checklist

• This is not a security-related bug/issue. If it is, please follow please follow the security policy.
• This is not a question or a support request. If you have any lotus related questions, please ask in the lotus forum.
• This is not a new feature request. If it is, please file a feature request instead.
• This is not an enhancement request. If it is, please file a improvement suggestion instead.
• I have searched on the issue tracker and the lotus forum, and there is no existing related issue or discussion.
• I am running the Latest release, or the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.
• I did not make any code changes to lotus.

Lotus component

• lotus daemon - chain sync
• lotus miner - mining and block production
• lotus miner/worker - sealing
• lotus miner - proving(WindowPoSt)
• lotus miner/market - storage deal
• lotus miner/market - retrieval deal
• lotus miner/market - data transfer
• lotus client
• lotus JSON-RPC API
• lotus message management (mpool)
• Other

Lotus Version

Daemon:  1.15.0-dev+mainnet+git.a09f38653+api1.3.0
Local: lotus-miner version 1.15.0-dev+mainnet+git.a09f38653

Describe the Bug

The markets instance dagstore migration causes invalid characters to be output in both the console log and corresponding log file:

Console Log
2022-02-16T16:04:17.445Z DEBUG advmgr sector-storage/piece_provider.go:169 result of first tryReadUnsealedPiece: r=&{ctx:0xc078a56780 getReader:0x16a57c0 pieceCid:{str:��� �{��2~%�8�k'��#�;�_g�P��� �3} len:34091302912 onClose:0x707700 closed:false seqAt:0 r:{Reader:0xc03d0b6780 Closer:0x16a5760} br:0xc03d0b67e0 rAt:0}, err=%!s(<nil>)

Log File
tryReadUnsealedPiece: r=&{ctx:0xc0f087e2c0 getReader:0x16a57c0 pieceCid:{str:�\81\E2�\92 \ED\00�\F6\E0'\BD\8DUt\91*\E4f\9E~\BCDhX1\F8\83\E1s�K\A7 \F6\A35} len:34091302912 onClose:0x707700 closed:false seqAt:0 r:{Reader:0xc0f0c8c420 Closer:0x16a5760} br:0xc0f0c8c480 rAt:0}, err=%!s(<nil>)

The issue was also present with M1 testing and does not appear to cause any runtime problems. It does however create issues when using the resulting log file for testing/debugging purposes.

For example: Attempting to trace the progress of a storage deal using grep "<Deal ID>" lotus-markets.log causes incorrect and truncated output. I believe this is because grep regards these invalid characters as escape characters. It also appears to occur using awk and sed.

I was able to work around this issue by using cat -A lotus-markets.log | grep "<Deal ID>" but the output formatting is compromised.

The ability to correctly examine and distribute log files without issue is very valuable. It would be great to see this minor issue resolved.

Many thanks!!

Logging Information

As above

Repo Steps

1. Run dagstore migration
2. Analyse resulting log file.