Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the full unseal snap deals sectors #8487

Closed
4 of 15 tasks
geoff-vball opened this issue Apr 14, 2022 · 1 comment
Closed
4 of 15 tasks

Optimize the full unseal snap deals sectors #8487

geoff-vball opened this issue Apr 14, 2022 · 1 comment
Assignees

Comments

@geoff-vball
Copy link
Contributor

Checklist

  • This is not a new feature or an enhancement to the Filecoin protocol. If it is, please open an FIP issue.
  • This is not a new feature request. If it is, please file a feature request instead.
  • This is not brainstorming ideas. If you have an idea you'd like to discuss, please open a new discussion on the lotus forum and select the category as Ideas.
  • I have a specific, actionable, and well motivated improvement to propose.

Lotus component

  • lotus daemon - chain sync
  • lotus miner - mining and block production
  • lotus miner/worker - sealing
  • lotus miner - proving(WindowPoSt)
  • lotus miner/market - storage deal
  • lotus miner/market - retrieval deal
  • lotus miner/market - data transfer
  • lotus client
  • lotus JSON-RPC API
  • lotus message management (mpool)
  • Other

Improvement Suggestion

Currently in order to regenerate the sector key for a snap deal sector requires a call to SealPreCommit2 which is expensive and shouldn't be necessary. Right now it is necessary because it generates the p_aux cache file that is required by the call to DecodeFrom. We should preserve p_aux when we call FinalizeReplicaUpdate in order to make unsealing the sector less resource intensive.

There may be other optimizations to be made to eliminate other unnecessary work in the ffi calls.

#8478 (comment)

@geoff-vball
Copy link
Contributor Author

This is addressed by #8478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants