Recucsive evm call traces contain raw params

[magik6k]

On wallaby we StateCall trace params look like:

"Params": "WGTLd4bXAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAoAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAK",
"Params": "WGTLd4bXAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAoAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAK",
"Params": null,
"Params": "y3eG1wAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAKAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAoAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACQ==",
"Params": null,
"Params": "y3eG1wAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAKAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAoAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACA==",
"Params": null,
"Params": "y3eG1wAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAKAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAoAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABw==", 

Subcall params are supposed to be a cbor byte array, but is just a raw array.

From ./lotus state --tipset @3913 compute-state --html.

Found when debugging filecoin-project/lotus#10038 with @shrenujbansal

[jennijuju]

are subcall params suppose to be cobra byte array only tho?

filecoin-project/builtin-actors#913

[shrenujbansal]

are subcall params suppose to be cobra byte array only tho?

filecoin-project/builtin-actors#913

Yes, that's the assumption we make everywhere in Lotus today
We need to make the encoding for subcalls consistent and make them a cbor byte array or include the codec in the call so we can properly decode the params

[Stebalien]

This has now been fixed in the FVM. However, codec information now needs to be plumbed through the FFI.

[Stebalien]

Fixed everywhere.