Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rpc] 合并jsonrpc库， 把我们的一些改动推送到上游去 #5346

Open
3 of 4 tasks
Tracked by #5979
hunjixin opened this issue Oct 8, 2022 · 2 comments
Open
3 of 4 tasks
Tracked by #5979

[rpc] 合并jsonrpc库， 把我们的一些改动推送到上游去 #5346

hunjixin opened this issue Oct 8, 2022 · 2 comments
Assignees
@hunjixin
Labels
C-enhancement Category: feature enhancement P2 Medium - we should get to this soon

Comments

@hunjixin
Copy link
Contributor

hunjixin commented Oct 8, 2022 •
edited
Loading

目前看我们的改动

  • 关于bind方法字段那一块的功能我们已经不在需要， 可以直接删除。
  • 关于错误码的改动，可以考虑和官方库融合起来
  • 关于重试的部分可能会有难度，全局retry字段和官方库配置retry tag的方式。 建议还是局部覆盖全局
  • 关于一些bug修复（错误处理和backoff）肯定是没有问题的。
@hunjixin hunjixin mentioned this issue Oct 8, 2022
Closed
45 tasks
@hunjixin hunjixin self-assigned this Oct 8, 2022
@hunjixin hunjixin added P1 High - we should be working on this now or in the immediate future C-enhancement Category: feature enhancement P2 Medium - we should get to this soon and removed P1 High - we should be working on this now or in the immediate future labels Oct 8, 2022
@hunjixin hunjixin changed the title 合并jsonrpc库， 把我们的一些改动推送到上游去 [rpc] 合并jsonrpc库， 把我们的一些改动推送到上游去 Oct 8, 2022
@Fatman13
Copy link
Contributor

Fatman13 commented Oct 8, 2022

关联：

@Fatman13 Fatman13 mentioned this issue Oct 21, 2022
Closed
38 tasks
@Fatman13 Fatman13 mentioned this issue Nov 4, 2022
Closed
45 tasks
@Fatman13 Fatman13 mentioned this issue May 22, 2023
Closed
1 task
@Fatman13
Copy link
Contributor

感觉官方不 review 了。。😂

@Fatman13 Fatman13 mentioned this issue May 22, 2023
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hunjixin hunjixin

Labels
C-enhancement Category: feature enhancement P2 Medium - we should get to this soon
Projects
Venus Project
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fatman13 @hunjixin