Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Right clicking column layout crashes app #16193

Closed
dmizz opened this issue Sep 13, 2024 · 31 comments · Fixed by #16612
Closed

Bug: Right clicking column layout crashes app #16193

dmizz opened this issue Sep 13, 2024 · 31 comments · Fixed by #16612
Labels
crash Bug reports involving a crash

Comments

@dmizz
Copy link

dmizz commented Sep 13, 2024

Important

Current workaround
Go to Files settings > Actions > Change the bindings for both Open Terminal and Open Terminal as Admin to something else (use a letter/number with as many modifiers as you wish; DO NOT use ~ or any of the keys to the right of P, L, M)

Description

Experiencing overall stability issues. I LOVE this app, but to use it for mission critical work I need it to be way more stable.

Main issues are:
Right clicking can cause a crash 25% of the time, especially in column mode it seems.
File transfers get hung up and cancel a ton.
Opening the app always lags and will fail sometimes.

Steps To Reproduce

  • Switch to Column View
  • Right click empty space in last column

Requirements

  • Fix crash

Files Version

3.7.0.0

Windows Version

10.0.22631.4169

Log File

debug.log

@dmizz dmizz added the bug label Sep 13, 2024
@Josh65-2201
Copy link
Member

Thanks for the report, Please update to 3.7.6 https://files.community/download and see if this is still an issue

@Josh65-2201 Josh65-2201 added the needs - additional info Needs more information from the reporter label Sep 13, 2024
@files-community files-community deleted a comment from alikhan134 Sep 14, 2024
@yaira2
Copy link
Member

yaira2 commented Sep 15, 2024

@dmizz thank you for your feedback, we're constantly working to improve stability and will continue to so.

I'd like to try and track down the crash you mentioned with right clicking. If you open the settings file (Settings > Advanced > Edit settings file), there should be a value under userid. If you send the value here, I can locate the crash in Sentry and do my best to debug this issue.

@dmizz
Copy link
Author

dmizz commented Sep 16, 2024 via email

@yaira2
Copy link
Member

yaira2 commented Sep 16, 2024

That's odd, this could also be why Files has been acting up for you. Can you try to uninstall and reinstall Files?

@Josh65-2201
Copy link
Member

I think it more likely that no programs are set to open Json files, Please try going to Files settings > About > Open log location > open settings folder > open user_settings.json

@dmizz
Copy link
Author

dmizz commented Sep 16, 2024 via email

@Josh65-2201
Copy link
Member

Email attachments don't work. You will have to click the View on GitHub link at the bottom of the email > Copy and paste or click the add attachment button to select the file > Wait until you don't see uploading in the text > Click the green comment button.

@dmizz
Copy link
Author

dmizz commented Sep 16, 2024

user_settings.json
k!

@yaira2
Copy link
Member

yaira2 commented Sep 16, 2024

I located a crash related to drag & drop, can you confirm if that's the issue you were referring to? This is also included in the log file you uploaded.

@dmizz
Copy link
Author

dmizz commented Sep 16, 2024 via email

@yaira2
Copy link
Member

yaira2 commented Sep 16, 2024

Are you using v3.7.6?

@dmizz
Copy link
Author

dmizz commented Sep 16, 2024 via email

@yaira2
Copy link
Member

yaira2 commented Sep 16, 2024

If the issue doesn't show in the log file, you might get more info from Event Viewer.

@StampeSystem
Copy link

I am facing exactly the same issues. Version 3.7.7.0. I am running in columns view. Every second time I am trying to open the context menu, the app is crashing.

This is what I get from the event viewer:
Protokollname: Application
Quelle: Application Error
Datum: 17.09.2024 16:48:29
Ereignis-ID: 1000
Aufgabenkategorie:Anwendungsabsturzereignisse
Ebene: Fehler
Schlüsselwörter:
Beschreibung:
Name der fehlerhaften Anwendung: Files.exe, Version: 1.0.0.0, Zeitstempel: 0x666b0000
Name des fehlerhaften Moduls: Microsoft.UI.Xaml.dll, Version: 3.1.5.0, Zeitstempel: 0xcd7cc268
Ausnahmecode: 0xc000027b
Fehleroffset: 0x00000000004051c5
ID des fehlerhaften Prozesses: 0x0xEC4
Startzeit der fehlerhaften Anwendung: 0x0x1DB09048C41DD7A
Pfad der fehlerhaften Anwendung: C:\Program Files\WindowsApps\49306atecsolution.FilesUWP_3.7.7.0_x64__et10x9a9vyk8t\Files.App\Files.exe
Pfad des fehlerhaften Moduls: C:\Program Files\WindowsApps\Microsoft.WindowsAppRuntime.1.5_5001.214.1843.0_x64__8wekyb3d8bbwe\Microsoft.UI.Xaml.dll
Berichtskennung: 1bc94954-9097-49a3-bcaf-ff231628f75f
Vollständiger Name des fehlerhaften Pakets: 49306atecsolution.FilesUWP_3.7.7.0_x64__et10x9a9vyk8t
Anwendungs-ID, die relativ zum fehlerhaften Paket ist: App
Ereignis-XML:



1000
0
2
100
0
0x8000000000000000

424249


Application



Files.exe
1.0.0.0
666b0000
Microsoft.UI.Xaml.dll
3.1.5.0
cd7cc268
c000027b
00000000004051c5
0xec4
0x1db09048c41dd7a
C:\Program Files\WindowsApps\49306atecsolution.FilesUWP_3.7.7.0_x64__et10x9a9vyk8t\Files.App\Files.exe
C:\Program Files\WindowsApps\Microsoft.WindowsAppRuntime.1.5_5001.214.1843.0_x64__8wekyb3d8bbwe\Microsoft.UI.Xaml.dll
1bc94954-9097-49a3-bcaf-ff231628f75f
49306atecsolution.FilesUWP_3.7.7.0_x64__et10x9a9vyk8t
App

@yaira2 yaira2 changed the title Overall Stability Bug: Right clicking crashes app Sep 17, 2024
@yaira2
Copy link
Member

yaira2 commented Sep 30, 2024

@dmizz Is this still an issue in the preview version? https://files.community/download/preview

@dmizz
Copy link
Author

dmizz commented Sep 30, 2024

Yes I just installed Files Preview and gave it a shot. Crashed on my second right click. It might be happening more when on Google Drive folders.
debug.log

@yaira2 yaira2 removed the needs - additional info Needs more information from the reporter label Sep 30, 2024
@yaira2 yaira2 moved this from 🆕 New to 🔖 Ready to build in Files task board Sep 30, 2024
@yaira2
Copy link
Member

yaira2 commented Sep 30, 2024

When you right click, are you right clicking in the last column? Can you also confirm if you're right clicking an empty space?

@dmizz
Copy link
Author

dmizz commented Sep 30, 2024 via email

@Josh65-2201 Josh65-2201 added the crash Bug reports involving a crash label Oct 2, 2024
@dmizz
Copy link
Author

dmizz commented Oct 3, 2024

just did a clean install of W11 for other reasons and was hoping this issue would sort of fix itself. Installed the latest Preview version. Crashed on right click immediately.
debug.log

@yaira2 yaira2 changed the title Bug: Right clicking crashes app Bug: Right clicking column view crashes app Oct 6, 2024
@dmizz
Copy link
Author

dmizz commented Oct 16, 2024

any updates? this is driving me crazy

@yaira2
Copy link
Member

yaira2 commented Oct 16, 2024

It's on our todo list

@Machaing
Copy link

Machaing commented Nov 5, 2024

i met the similar issue

Files app log looks very clean, but i found “window event reporter” have some valuable info:
-----------------------------------------------------------------------------------------------------
错误应用程序名称: Files.exe,版本: 1.0.0.0,时间戳: 0x666b0000
错误模块名称: Microsoft.UI.Xaml.dll,版本: 3.1.5.0,时间戳: 0xc7b159d6
异常代码: 0xc000027b
错误偏移量: 0x0000000000405235
错误进程 ID: 0x0x5840
错误应用程序启动时间: 0x0x1DB2F2CEA2E8AED
错误应用程序路径: C:\Program Files\WindowsApps\49306atecsolution.FilesUWP_3.7.11.0_x64__et10x9a9vyk8t\Files.App\Files.exe
错误模块路径: C:\Program Files\WindowsApps\Microsoft.WindowsAppRuntime.1.5_5001.275.500.0_x64__8wekyb3d8bbwe\Microsoft.UI.Xaml.dll
报告 ID: 7ed953b6-216e-41d9-8df2-365054e7e7ff
错误程序包全名: 49306atecsolution.FilesUWP_3.7.11.0_x64__et10x9a9vyk8t
错误程序包相对应用程序 ID: App
-----------------------------------------------------------------------------------------------------

@dmizz
Copy link
Author

dmizz commented Nov 5, 2024

I installed .NET 6.0 SDK and the issue persists.

@Josh65-2201 Josh65-2201 changed the title Bug: Right clicking column view crashes app Bug: Right clicking column layout crashes app Nov 6, 2024
@asimhamid
Copy link

asimhamid commented Nov 18, 2024

Same! In Columns layout, right clicking on a folder (rarely crashes when clicking on an item) in my case, crashes every time, blank area crashes the app most of the time.

@ferrariofilippo
Copy link
Contributor

ferrariofilippo commented Nov 19, 2024

First, quick (& temp) fix:

  • Go to Settings->Actions
  • Change the bindings for both Open Terminal and Open Terminal as Admin to something else (use a letter/number with as many modifiers as you wish; DO NOT use ~ or any of the keys to the right of P, L, M)

Cause of the crash:
The context menu is implemented with Microsoft.UI.Xaml.Input, which uses the VirtualKey enum to specify the KeyboardAccelerator. The issue is that VirtualKey does not support Oem keys.

Concerned code:
Files.App.Data.Models.ContextMenuFlyoutItemViewModelBuilder.Build()

viewModel.KeyboardAccelerator = new Microsoft.UI.Xaml.Input.KeyboardAccelerator()
{
	Key = (VirtualKey)command.HotKeys[0].Key, // <------- This line here
	Modifiers = (VirtualKeyModifiers)command.HotKeys[0].Modifier
};
viewModel.KeyboardAcceleratorTextOverride = command.HotKeys[0].LocalizedLabel;

Probably related: microsoft/microsoft-ui-xaml#708

@Alovchin91
Copy link

Same issue here. After using the workaround the app doesn't crash anymore, but the context menu flickers and doesn't appear sometimes. Also, in the Columns view there are constant unexpected scrolls to the left.

@Josh65-2201
Copy link
Member

Those are known issue, We're tracking this in #15776. You can check there or click subscribe in the right sidebar for updates.

@Alovchin91
Copy link

Alovchin91 commented Nov 20, 2024

I've made a screen recording of the context menu flickering if it helps.

Untitled.mov

This essentially renders the Columns layout unusable :(

@Alovchin91
Copy link

@Josh65-2201 Should I repost this video in the other thread?

@Josh65-2201
Copy link
Member

If you want it not required though

@yaira2
Copy link
Member

yaira2 commented Dec 17, 2024

A fix will be included in the next update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash Bug reports involving a crash
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

8 participants