Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Rename "Files.App (Package)" to "Files.Package" in the directory tree #16350

Closed
Lamparter opened this issue Oct 16, 2024 · 6 comments

Comments

@Lamparter
Copy link
Contributor

Description

It's unnecessary and somewhat confusing to have the name "Files.App (Package)" in the directory tree (src). It should better be named Files.Package to match the configuration manager.

Concerned code

N/A

Gains

  • Better understanding of folder structure
  • Developer will understand the link between "Files.App (Package)" and "Files.Package" as it appears in the editor.

Requirements

  • Rename directory "Files.App (Package)" to "Files.Package"

Comments

No response

@0x5bfa
Copy link
Member

0x5bfa commented Oct 16, 2024

  • moving appxmanifest to another place would break the auto update

@0x5bfa
Copy link
Member

0x5bfa commented Oct 16, 2024

To rename, Files.App.Package makes more sense but we'd not rename or move until msixbundle is supported in the single packing project.

@Lamparter
Copy link
Contributor Author

To rename, Files.App.Package makes more sense but we'd not rename or move until msixbundle is supported in the single packing project.

Yes you're right, like in FluentHub. However, that's how it currently is (Files.Package in Configuration Manager)

@yaira2
Copy link
Member

yaira2 commented Oct 16, 2024

#12475 (comment)

@Lamparter
Copy link
Contributor Author

Lamparter commented Oct 16, 2024

It's possible to publish a package from a single package project though, right?

I think it's like that in Rebound 11.

@yaira2
Copy link
Member

yaira2 commented Oct 16, 2024

Bundles aren't supported yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants