Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(upload): add posibility to disable s3 integrity check (md5 gener… #299

Merged
merged 4 commits into from
Oct 29, 2019

Conversation

pcholuj
Copy link
Contributor

@pcholuj pcholuj commented Oct 29, 2019

Add disable integrity check option for uploads (speeds up upload process)

@pcholuj pcholuj self-assigned this Oct 29, 2019
@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #299 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
+ Coverage   99.05%   99.06%   +<.01%     
==========================================
  Files          32       32              
  Lines        1481     1491      +10     
  Branches      275      281       +6     
==========================================
+ Hits         1467     1477      +10     
  Misses         14       14
Impacted Files Coverage Δ
src/schema/upload.schema.ts 100% <ø> (ø) ⬆️
src/lib/client.ts 100% <ø> (ø) ⬆️
src/schema/store.schema.ts 100% <ø> (ø) ⬆️
src/lib/picker.ts 100% <ø> (ø) ⬆️
src/lib/api/upload/file.ts 97.91% <100%> (+0.09%) ⬆️
src/lib/api/upload/uploaders/s3.ts 98.8% <100%> (+0.01%) ⬆️
src/config.ts 100% <100%> (ø) ⬆️
src/lib/api/upload/uploaders/abstract.ts 100% <100%> (ø) ⬆️
src/lib/api/upload/upload.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc29f1a...80813d2. Read the comment docs.

@pcholuj pcholuj merged commit 207e4c7 into master Oct 29, 2019
@pcholuj pcholuj deleted the feature/integrityCheck branch October 29, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant